Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HELM-532: Sort on basis of Chart Version #13846

Merged
merged 1 commit into from
May 22, 2024
Merged

HELM-532: Sort on basis of Chart Version #13846

merged 1 commit into from
May 22, 2024

Conversation

Kartikey-star
Copy link
Contributor

Default sorting is by logical semver, with latest being the bottom of the list (default selected) and top of the list being the oldest chart.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot

@Kartikey-star: This pull request references HELM-532 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Default sorting is by logical semver, with latest being the bottom of the list (default selected) and top of the list being the oldest chart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/backend Related to backend approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 14, 2024
@Kartikey-star
Copy link
Contributor Author

/test-backend

@lokanandaprabhu
Copy link
Contributor

Tested using cluster bot. Working fine.

Screen.Recording.2024-05-14.at.5.20.53.PM.mov

@sanketpathak
Copy link
Contributor

Verified with admin and non-admin users
Screenshot 2024-05-14 at 6 56 42 PM
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 14, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 14, 2024 •
edited by openshift-ci bot

@Kartikey-star: This pull request references HELM-532 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Default sorting is by logical semver, with latest being the bottom of the list (default selected) and top of the list being the oldest chart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dperaza4dustbit
dperaza4dustbit approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels May 14, 2024
@Kartikey-star
sort on basis of semver
1663414 
Signed-off-by: Kartikey-star <kmamgain@redhat.com>
@Kartikey-star
Copy link
Contributor Author

/test e2e-gcp-console

@lokanandaprabhu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit, Kartikey-star, lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Kartikey-star
Copy link
Contributor Author

/test e2e-gcp-console

@Kartikey-star
Copy link
Contributor Author

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label May 21, 2024
@Kartikey-star
Copy link
Contributor Author

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 21, 2024
@lokanandaprabhu
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 21, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 363abe6 and 2 for PR HEAD 1663414 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9d15ca4 and 1 for PR HEAD 1663414 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@Kartikey-star: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d268683 into openshift:master May 22, 2024
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405221214.p0.gd268683.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dperaza4dustbit dperaza4dustbit dperaza4dustbit approved these changes

@lokanandaprabhu lokanandaprabhu lokanandaprabhu approved these changes

@florkbr florkbr Awaiting requested review from florkbr

Assignees

@dperaza4dustbit dperaza4dustbit

@lokanandaprabhu lokanandaprabhu

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Kartikey-star @openshift-ci-robot @lokanandaprabhu @sanketpathak @openshift-bot @dperaza4dustbit