-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-33587: Fix password set to Secret created through Start Pipeline form #13844
OCPBUGS-33587: Fix password set to Secret created through Start Pipeline form #13844
Conversation
@vikram-raj: This pull request references Jira Issue OCPBUGS-33587, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @jerolimov |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lokanandaprabhu, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
@openshift-bot: This pull request references Jira Issue OCPBUGS-33587, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
@openshift-bot: This pull request references Jira Issue OCPBUGS-33587, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label acknowledge-critical-fixes-only |
/jira refresh |
@vikram-raj: This pull request references Jira Issue OCPBUGS-33587, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0b3fd7c
into
openshift:master
@vikram-raj: Jira Issue OCPBUGS-33587: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-33587 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fixes: https://issues.redhat.com/browse/OCPBUGS-33587
Description: The Secret password was not set correctly last character of the password was missing in the case of a Secret created through the Start Pipeline form. This PR fixes this issue using a callback of the state.
Before:
The password is qwerty, but the last character is missing in the password.
Secret-pass-before.mov
After:
Secret-pass-after.mov