Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CONSOLE-3986: Enable French and Spanish in the OCP Console #13836

Closed

Conversation

cyril-ui-developer
Copy link
Contributor

@cyril-ui-developer cyril-ui-developer commented May 10, 2024

THIS BATCH OF TRANSLATIONS HAS INCORRECT STRING PLURALIZATIONS FOR "FR" AND "ES" LANGS

Adding latest translations from Memsource project including the fr and es languages
https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

After:

Screenshot 2024-05-10 at 3 51 54 PM Screenshot 2024-05-10 at 3 52 07 PM

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 10, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cloudbehl and gkarat May 10, 2024 11:00
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console labels May 10, 2024
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyril-ui-developer
Once this PR has been reviewed and has the lgtm label, please assign kyoto for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project including the fr and es languages
https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

@cyril-ui-developer: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

"Min available {{minAvailable}} of {{count}} pod_one": "Minimum disponible {{minAvailable}} sur {{count}} pod_one",
"Min available {{minAvailable}} of {{count}} pod_other": "Minimum disponible {{minAvailable}} sur {{count}} pod_other",
"Max unavailable {{maxUnavailable}} of {{count}} pod_one": "Maximum non disponible {{maxUnavailable}} sur {{count}} pod_one",
"Max unavailable {{maxUnavailable}} of {{count}} pod_other": "Maximum non disponible {{maxUnavailable}} sur {{count}} pod_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect plural translations for count variables

"{{count}} Namespaces_one": "{{count}} Namespaces_one",
"{{count}} Namespaces_other": "{{count}} Namespaces_other",
"Console plugin_one": "Consola plugin_one",
"Console plugin_other": "Consola plugin_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect pluralization

"All Namespaces": "Tous les espaces de noms",
"Managed Namespaces": "Espaces de noms gérés",
"{{count}} Namespaces_one": "{{count}} Namespaces_one",
"{{count}} Namespaces_other": "{{count}} Namespaces_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization

"{{count}} Namespaces_one": "{{count}} Namespaces_one",
"{{count}} Namespaces_other": "{{count}} Namespaces_other",
"Console plugin_one": "Console plugin_one",
"Console plugin_other": "Console plugin_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization

{
"Notifications": "Notificaciones",
"{{count}} unread_one": "{{count}} unread_one",
"{{count}} unread_other": "{{count}} unread_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization

"Resource type": "Type de ressource",
"Total used": "Total utilisé",
"{{count}} resource reached quota_one": "{{count}} ressource a atteint quota_one",
"{{count}} resource reached quota_other": "{{count}} ressource a atteint quota_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization.

"Identities": "Identités",
"User details": "Détails de l’utilisateur",
"There is {{count}} {{variant}} alert._one": "Il y a {{count}} {{variant}} alerte._one",
"There is {{count}} {{variant}} alert._other": "Il y a {{count}} {{variant}} alertes._other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization.

"Copy to clipboard": "Copier dans le Presse-papiers",
"Just now": "À l’instant",
"{{count}} toleration_one": "{{count}} toleration_one",
"{{count}} toleration_other": "{{count}} toleration_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization.

"{{count}} line_one": "{{count}} line_one",
"{{count}} line_other": "{{count}} line_other",
"Resume stream and show {{count}} new line_one": "Reprendre la diffusion et afficher {{count}} nouvelle line_one",
"Resume stream and show {{count}} new line_other": "Reprendre la diffusion et afficher {{count}} nouvelles line_other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization.

"Your 60-day self-support trial expired.": "Votre essai d’auto-assistance de 60 jours a expiré.",
"Your 60-day self-support trial will end in < 1 day.": "Votre essai d’auto-assistance de 60 jours se terminera dans < 1 jour.",
"Your 60-day self-support trial will end in {{count}} day on {{date}}._one": "Votre essai d’auto-assistance de 60 jours se terminera dans {{count}} jour le {{date}}._one",
"Your 60-day self-support trial will end in {{count}} day on {{date}}._other": "Votre essai d’auto-assistance de 60 jours se terminera dans {{count}} jours le {{date}}._other",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong pluralization.

@cyril-ui-developer
Copy link
Contributor Author

/hold
Until wrong pluralization issue is resolved.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 10, 2024

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adding latest translations from Memsource project including the fr and es languages
https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

After:

Screenshot 2024-05-10 at 3 51 54 PM Screenshot 2024-05-10 at 3 52 07 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024

@cyril-ui-developer: This pull request references CONSOLE-3986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

THIS BATCH OF TRANSLATIONS HAS INCORRECT STRING PLURALIZATIONS FOR "FR" AND "ES" LANGS

Adding latest translations from Memsource project including the fr and es languages
https://cloud.memsource.com/web/project2/show/TBjFI3T6ck8Bd92vkQmtk3

After:

Screenshot 2024-05-10 at 3 51 54 PM Screenshot 2024-05-10 at 3 52 07 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cyril-ui-developer
Copy link
Contributor Author

Closed in favor of PR

1 similar comment
@cyril-ui-developer
Copy link
Contributor Author

Closed in favor of PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/shared Related to console-shared component/topology Related to topology do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants