OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI #13829

cyril-ui-developer · 2024-05-08T20:05:13Z

Before:

After:

openshift-ci-robot · 2024-05-08T20:05:15Z

@cyril-ui-developer: No Jira issue with key WOCPBUGS-29777 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-08T20:13:20Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-08T20:21:55Z

/jira refresh

cyril-ui-developer · 2024-05-09T00:35:04Z

/retest

openshift-ci-robot · 2024-05-09T14:17:24Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

Before:

After:

Screencast on how to validate the change

pvc-readwriteoncepod-access-mode.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig · 2024-05-09T14:49:59Z

@yuvalgalanti shall we keep using radio buttons here or lets switch to dropdown ?

openshift-ci-robot · 2024-05-09T14:50:04Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

Before:

After:

Screencast on how to validate the change

pvc-readwriteoncepod-access-mode.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-09T14:50:07Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

After:

Screencast on how to validate the change

pvc-readwriteoncepod-access-mode.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-09T16:17:44Z

/retest

cyril-ui-developer · 2024-05-09T16:25:50Z

frontend/public/components/storage/shared.ts

@@ -23,31 +28,32 @@ type ProvisionerAccessModeMapping = {
  [provisioner: string]: AccessModeMapping;
 };

-// See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes for more details
+// See https://kubernetes.io/docs/concepts/storage/persistent-volumes/#types-of-persistent-volumes and
+// https://docs.openshift.com/container-platform/4.15/storage/understanding-persistent-storage.html for more details
 export const provisionerAccessModeMapping: ProvisionerAccessModeMapping = Object.freeze({


FYI: Please verify PVC - Storage Class Provisioners below if any is missing the ReadWriteOncePod Access Mode?

cyril-ui-developer · 2024-05-09T16:26:48Z

/assign @jhadvig @bipuladh PTAL, thanks.

cyril-ui-developer · 2024-05-10T02:17:52Z

/retest

yuvalgalanti · 2024-05-12T07:39:39Z

@yuvalgalanti shall we keep using radio buttons here or let's switch to dropdown?
I see what you are saying, since we have 4 options now I think having the access mode selection as a single select dropdown menu makes more sense and aligns with the convention in the OCP console.

cyril-ui-developer · 2024-05-20T14:53:20Z

/retest

cyril-ui-developer · 2024-05-23T23:47:34Z

/retest

openshift-ci-robot · 2024-05-28T16:52:51Z

@cyril-ui-developer: This pull request references Jira Issue OCPBUGS-29777, which is invalid:

expected the bug to target either version "4.17." or "openshift-4.17.", but it targets "4.16.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Before:

After:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cyril-ui-developer · 2024-05-28T20:56:03Z

/retest

cyril-ui-developer · 2024-05-28T22:09:19Z

/retest

openshift-ci · 2024-05-31T14:42:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cyril-ui-developer, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cyril-ui-developer · 2024-05-31T19:48:08Z

/retest

cyril-ui-developer · 2024-06-03T02:14:46Z

/retest

cyril-ui-developer · 2024-06-03T15:30:36Z

/retest

cyril-ui-developer · 2024-06-03T19:53:50Z

/retest

cyril-ui-developer · 2024-06-04T19:51:29Z

/retest

openshift-ci · 2024-06-05T00:21:55Z

@cyril-ui-developer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	`73ef85d`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

cyril-ui-developer · 2024-06-05T12:38:56Z

/retest

openshift-ci bot requested review from dtaylor113 and zherman0 May 8, 2024 20:07

openshift-ci bot added the component/core Related to console core functionality label May 8, 2024

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from ebcdb45 to 0506d1e Compare May 8, 2024 20:12

cyril-ui-developer changed the title ~~[WOCPBUGS-29777:~~ [WIP] OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI May 8, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from 0506d1e to c5fca82 Compare May 8, 2024 20:41

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 9, 2024

cyril-ui-developer changed the title ~~[WIP] OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI~~ OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI May 9, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024

jhadvig closed this May 9, 2024

jhadvig reopened this May 9, 2024

cyril-ui-developer commented May 9, 2024

View reviewed changes

bipuladh approved these changes May 10, 2024

View reviewed changes

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from c5fca82 to 3ace7ca Compare May 10, 2024 11:47

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch 2 times, most recently from ce62fad to aa9a42d Compare May 21, 2024 23:40

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from aa9a42d to fd51f09 Compare May 28, 2024 15:51

openshift-ci bot added the component/pipelines Related to pipelines-plugin label May 28, 2024

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch 2 times, most recently from 018b143 to dbc64b7 Compare May 28, 2024 16:19

openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 28, 2024

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from dbc64b7 to 8e86d33 Compare May 28, 2024 17:02

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch 3 times, most recently from 65eb4dd to 249456d Compare May 31, 2024 13:22

pvc-rwop-accessmode-not-available

73ef85d

cyril-ui-developer force-pushed the pvc-rwop-accessmode-not-available branch from 249456d to 73ef85d Compare May 31, 2024 13:32

vikram-raj approved these changes May 31, 2024

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024

OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI #13829

Are you sure you want to change the base?

OCPBUGS-29777: RWOP accessMode is not available on OpenShift console UI #13829

Conversation

cyril-ui-developer commented May 8, 2024 • edited

Before:

After:

openshift-ci-robot commented May 8, 2024

openshift-ci-robot commented May 8, 2024

cyril-ui-developer commented May 8, 2024

cyril-ui-developer commented May 9, 2024

openshift-ci-robot commented May 9, 2024

Before:

After:

Screencast on how to validate the change

jhadvig commented May 9, 2024

openshift-ci-robot commented May 9, 2024

Before:

After:

Screencast on how to validate the change

openshift-ci-robot commented May 9, 2024

Before:

After:

Screencast on how to validate the change

cyril-ui-developer commented May 9, 2024

cyril-ui-developer May 9, 2024

Choose a reason for hiding this comment

cyril-ui-developer commented May 9, 2024

cyril-ui-developer commented May 10, 2024

yuvalgalanti commented May 12, 2024

cyril-ui-developer commented May 20, 2024

cyril-ui-developer commented May 23, 2024

openshift-ci-robot commented May 28, 2024

Before:

After:

cyril-ui-developer commented May 28, 2024

cyril-ui-developer commented May 28, 2024

openshift-ci bot commented May 31, 2024

cyril-ui-developer commented May 31, 2024

cyril-ui-developer commented Jun 3, 2024

cyril-ui-developer commented Jun 3, 2024

cyril-ui-developer commented Jun 3, 2024

cyril-ui-developer commented Jun 4, 2024

openshift-ci bot commented Jun 5, 2024

cyril-ui-developer commented Jun 5, 2024

cyril-ui-developer commented May 8, 2024 •

edited