OCPBUGS-31733: Remove CPMS manifest for vSphere platform #6239
Conversation
The control-plane-machine-set (CPMS) cluster operator fails to deploy on 4.16-ec.5 build for ABI deployments on vSphere. That build removed the CPMS feature gate. Because ABI and assisted deployments do not create or include machines in the manifests, and the control plane machine operator expects machines to be present for each control plane node, the CO fails to deploy. The CPMS manifest should be removed for ABI and other UPI-like deployments. For UPI there is documentation indicating the CPMS manifest must be removed: https://docs.openshift.com/container-platform/4.15/installing/installing_vsphere/upi/installing-vsphere.html#installation-user-infra-generate-k8s-manifest-ignition_installing-vsphere
openshift-ci-robot
added
jira/severity-critical
|
@rwsu: This pull request references Jira Issue OCPBUGS-31733, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/XS
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6239 +/- ##
==========================================
+ Coverage 68.28% 68.57% +0.29%
==========================================
Files 240 241 +1
Lines 35799 36641 +842
==========================================
+ Hits 24445 25127 +682
- Misses 9198 9336 +138
- Partials 2156 2178 +22
|
|
/test ? |
|
@adriengentil: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-vsphere-assisted-4-12 |
|
/test edge-e2e-vsphere-assisted-4-14 |
|
let's see if we can test with older ocp versions on vsphere |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, rwsu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test edge-e2e-vsphere-assisted-4-14 |
2 similar comments
|
/test edge-e2e-vsphere-assisted-4-14 |
|
/test edge-e2e-vsphere-assisted-4-14 |
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@rwsu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 19e0de2
into
openshift:master
|
@rwsu: Jira Issue OCPBUGS-31733: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31733 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405022319.p0.g19e0de2.assembly.stream.el9 for distgit ose-agent-installer-api-server. |
|
Fix included in accepted release 4.16.0-0.nightly-2024-05-03-091818 |
… permanently failing (openshift#51340)" Issues solved by openshift/assisted-service#6239 This reverts commit d0ecb3b.
The control-plane-machine-set (CPMS) cluster operator fails to deploy on 4.16-ec.5 build for ABI deployments on vSphere. That build removed the CPMS feature gate.
Because ABI and assisted deployments do not create or include machines in the manifests, and the control plane machine operator expects machines to be present for each control plane node, the CO fails to deploy.
The CPMS manifest should be removed for ABI and other UPI-like deployments.
For UPI there is documentation indicating the CPMS manifest must be removed: https://docs.openshift.com/container-platform/4.15/installing/installing_vsphere/upi/installing-vsphere.html#installation-user-infra-generate-k8s-manifest-ignition_installing-vsphere
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist