AGENT-869: Implement a new auth type for ABI

[pawanpinjarkar]

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@pawanpinjarkar: This pull request references AGENT-869 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pawanpinjarkar
Once this PR has been reviewed and has the lgtm label, please assign crystalchun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pawanpinjarkar]

/hold

[codecov]

Codecov Report

Attention: Patch coverage is 22.22222% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 68.21%. Comparing base (904ee71) to head (3940b8e).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6174      +/-   ##
==========================================
- Coverage   68.29%   68.21%   -0.08%     
==========================================
  Files         241      242       +1     
  Lines       35863    35915      +52     
==========================================
+ Hits        24491    24501      +10     
- Misses       9212     9252      +40     
- Partials     2160     2162       +2     

Files	Coverage Δ
internal/bminventory/inventory_v2_handlers.go	56.60% <100.00%> (ø)
internal/cluster/auth.go	78.12% <100.00%> (ø)
...nternal/controller/controllers/agent_controller.go	74.54% <ø> (ø)
internal/controller/controllers/agent_reclaimer.go	96.92% <ø> (ø)
...oller/controllers/clusterdeployments_controller.go	72.03% <ø> (ø)
internal/controller/controllers/common.go	79.50% <ø> (ø)
...rnal/controller/controllers/infraenv_controller.go	64.13% <ø> (ø)
...l/host/hostcommands/download_boot_artifacts_cmd.go	75.00% <ø> (ø)
pkg/auth/authenticator.go	100.00% <100.00%> (ø)
pkg/auth/agent_local_authenticator.go	16.00% <16.00%> (ø)

... and 2 files with indirect coverage changes

[openshift-ci]

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/edge-e2e-metal-assisted	3940b8e	link	true	/test edge-e2e-metal-assisted
ci/prow/edge-lint	3940b8e	link	true	/test edge-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.