New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-15008: Create a v1beta2 API for AgentClusterInstall #5881
base: master
Are you sure you want to change the base?
Conversation
This is identical to v1beta1 but with the singular VIP fields removed
@carbonin: This pull request references MGMT-15008 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
This PR adds a new API version for AgentClusterInstall, adds a conversion webhook to ensure the latest version is stored and updates the kubeAPI controllers to operate on the new version.
List all the issues related to this PR
https://issues.redhat.com/browse/MGMT-15008
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist