Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose chunksize variable for S3 storage driver #1864

Merged
merged 2 commits into from May 3, 2024

Conversation

deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented Apr 22, 2024

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

Hello @deepsm007! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@deepsm007 deepsm007 changed the title Expose chunkzie variable for S3 storage driver WIP Expose chunkzie variable for S3 storage driver Apr 22, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2024
@deepsm007
Copy link
Contributor Author

/test all

@flavianmissi
Copy link
Member

left a comment. this looks good for a registry perspective otherwise.

imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
@deepsm007 deepsm007 force-pushed the add-chunksize-var branch 2 times, most recently from 5dcce6b to 4e862cc Compare April 22, 2024 15:47
@deepsm007 deepsm007 changed the title WIP Expose chunkzie variable for S3 storage driver Expose chunkzie variable for S3 storage driver Apr 22, 2024
@deepsm007 deepsm007 marked this pull request as ready for review April 22, 2024 16:02
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@deepsm007 deepsm007 changed the title Expose chunkzie variable for S3 storage driver Expose chunksize variable for S3 storage driver Apr 22, 2024
@deepsm007 deepsm007 force-pushed the add-chunksize-var branch 5 times, most recently from e5adb0f to d8b5d7b Compare April 22, 2024 20:31
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 22, 2024
imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
imageregistry/v1/types.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 23, 2024
@deepsm007
Copy link
Contributor Author

/assign @JoelSpeed

@deepsm007 deepsm007 force-pushed the add-chunksize-var branch 3 times, most recently from e351ff9 to e74c2b7 Compare May 2, 2024 12:11
@JoelSpeed
Copy link
Contributor

Verify failures are because we cannot detect that you are duplicating the CRD that already exists, however, we do want you to fix ListsMustHaveSSATags. Can you raise a separate PR that fixes all of the SSA tags on the image registry type? This will be needed to move forward

The tests are genuinely broken, you are not using the correct casing for you field which means it's being dropped, please fix the casing

features/features.go Outdated Show resolved Hide resolved
@deepsm007
Copy link
Contributor Author

/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
@flavianmissi
Copy link
Member

PR needs rebase and the verify-crd-schema job is still broken.
The code otherwise lgtm from an image registry perspective.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
@JoelSpeed
Copy link
Contributor

/lgtm

Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed
/override ci/prow/verify-crd-schema

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/lgtm

Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deepsm007
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2024
@deepsm007
Copy link
Contributor Author

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 56da039 and 2 for PR HEAD 62065c7 in total

@deads2k
Copy link
Contributor

deads2k commented May 3, 2024

Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed
/override ci/prow/verify-crd-schema

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

Failures in the CRD schema check are pre-existing and from corev1 types that cannot be fixed
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 62065c7 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0a2abb2 into openshift:master May 3, 2024
17 of 18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202405040320.p0.g0a2abb2.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

gcs278 pushed a commit to gcs278/api that referenced this pull request May 6, 2024
Expose chunksize variable for S3 storage driver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants