New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29774: Add hypershift cluster profile #1858
base: master
Are you sure you want to change the base?
Conversation
@ashwindasr: This pull request references Jira Issue OCPBUGS-29774, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @ashwindasr! Some important instructions when contributing to openshift/api: |
Skipping CI for Draft Pull Request. |
/test all |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ashwindasr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to find every instance of
api/networkoperator/v1/generated.proto
Line 37 in 2624175
// +kubebuilder:metadata:annotations=include.release.openshift.io/ibm-cloud-managed=true |
config/v1/feature_gates.go
Outdated
Hypershift = ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") | ||
SelfManaged = ClusterProfileName("include.release.openshift.io/self-managed-high-availability") | ||
AllClusterProfiles = []ClusterProfileName{Hypershift, SelfManaged} | ||
Hypershift = ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to create an IBMCloudManaged
and make this an alias to that, with a view to deprecating and removing this version of HyperShift
over time
/test all |
@ashwindasr: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Since HyperShift / Hosted Control Plane have adopted
include.release.openshift.io/ibm-cloud-managed
, to tailor the resources of clusters running in the ROKS IBM environment, theinclude.release.openshift.io/hypershift
addition will allow Hypershift to express different profile choices than ROKS