NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller #1826

miheer · 2024-03-23T01:12:23Z

Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

config/v1/types_ingress.go - Adds an API field eip-allocations in the cluster ingress config object whose value is set by the installer using install-config.yaml

operator/v1/types_ingress.go - Adds an API field eip-allocations in the Ingress Controller CR object using which the Ingress Operator scales an Ingress Controller with service type balancer whose annotation

service.beta.kubernetes.io/aws-load-balancer-eip-allocations is set by the value of the field eip-allocations of the Ingress Controller.

Epic: https://issues.redhat.com/browse/NE-1274

Story: https://issues.redhat.com/browse/NE-1516

openshift-ci-robot · 2024-03-23T01:12:26Z

@miheer: This pull request references NE-1516 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

config/v1/types_ingress.go - Adds an API field eip-allocations in the cluster ingress config object whose value is set by the installer using install-config.yaml operator/v1/types_ingress.go - Adds an API field eip-allocations in the Ingress Controller CR object using which the Ingress Operator scales an Ingress Controller with service type balancer whose annotation service.beta.kubernetes.io/aws-load-balancer-eip-allocations is set by the value of the field eip-allocations of the Ingress Controller. Epic: https://issues.redhat.com/browse/NE-1274
Story: https://issues.redhat.com/browse/NE-1516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-03-23T01:12:31Z

Hello @miheer! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2024-03-23T01:13:09Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miheer
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-03-23T01:13:27Z

@miheer: This pull request references NE-1516 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller

config/v1/types_ingress.go - Adds an API field eip-allocations in the cluster ingress config object whose value is set by the installer using install-config.yaml

operator/v1/types_ingress.go - Adds an API field eip-allocations in the Ingress Controller CR object using which the Ingress Operator scales an Ingress Controller with service type balancer whose annotation

service.beta.kubernetes.io/aws-load-balancer-eip-allocations is set by the value of the field eip-allocations of the Ingress Controller.

Epic: https://issues.redhat.com/browse/NE-1274

Story: https://issues.redhat.com/browse/NE-1516

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

deads2k · 2024-03-25T13:01:17Z

config/v1/types_ingress.go

@@ -151,8 +151,22 @@ type AWSIngressSpec struct {
 	// +kubebuilder:validation:Enum:=NLB;Classic
 	// +kubebuilder:validation:Required
 	Type AWSLBType `json:"type,omitempty"`
+
+	// networkLoadBalancerParameters holds configuration parameters for an AWS
+	// network load balancer. Present only if type is NLB.


Add CEL to enforce this.

deads2k · 2024-03-25T13:03:17Z

config/v1/types_ingress.go

+// AWSNetworkLoadBalancerParameters holds configuration parameters for an
+// AWS Network load balancer.
+type AWSNetworkLoadBalancerParameters struct {
+	EIPAllocations EIPAllocations `json:"eip-allocations,omitempty"`


What does this do? Why is it plural, but only has a single value? Why would I want to set it?

https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/guide/service/annotations/#eip-allocations
service.beta.kubernetes.io/aws-load-balancer-eip-allocations specifies a list of elastic IP address configuration for an internet-facing NLB.
So, when the eip-allocations field is set in the Ingress Controller CR which is comma separated value of type string, we set the value of the service of load balancer type with service annotation mentioned above.
Do you think we should specify this as an array and then seperate the value in the ingress controller based on the delimiter comma ?

I added an array.

deads2k · 2024-03-25T13:19:16Z

config/v1/types_ingress.go

+	// network load balancer. Present only if type is NLB.
+	//
+	// +optional
+	NetworkLoadBalancerParameters *AWSNetworkLoadBalancerParameters `json:"networkLoadBalancer,omitempty"`


Add a featuregate to this field. It's done by

add a featuregate like https://github.com/openshift/api/blob/master/config/v1/feature_gates.go#L182-L188

add a // +openshift:enable:FeatureGate=Example comment to this type

run hack/update-payload-featuregates.sh

run make update

This will add the schema to TechPreviewNoUpgrade (files now auto-generated). Once your automated tests are passing or QE signs off, a PR enabling by default can flip the gate to true ref

OK. I need to try this. Thanks!

candita · 2024-03-27T15:38:48Z

/assign @Miciah

deads2k · 2024-04-18T19:01:50Z

config/v1/feature_gates.go

+							reportProblemsToJiraComponent("Routing").
+							contactPerson("miheer").
+							productScope(ocpSpecific).
+							enableIn(TechPreviewNoUpgrade).


There's now also a DevPreview you probably want to enable it on. DevPreviewNoUpgrade, TechPreviewNoUpgrade

deads2k · 2024-04-18T19:03:36Z

config/v1/types_ingress.go

 }

+// AWSNetworkLoadBalancerParameters holds configuration parameters for an


Can you link to where the list parameters is? Can they set anything? Are there any formating requirements?

hi @deads2k ! sorry I did not get this point. Can you please explain more on this ?

deads2k · 2024-04-18T19:04:34Z

config/v1/types_ingress.go

+// AWS Network load balancer.
+// +openshift:enable:FeatureGate=SetEIPForNLBIngressController
+type AWSNetworkLoadBalancerParameters struct {
+	EIPAllocations []EIPAllocations `json:"eipAllocations,omitempty"`


no omitempty.

deads2k · 2024-04-18T19:05:07Z

config/v1/types_ingress.go

 }

+// AWSNetworkLoadBalancerParameters holds configuration parameters for an
+// AWS Network load balancer.
+// +openshift:enable:FeatureGate=SetEIPForNLBIngressController


this probably more appropriately belongs on either networkLoadBalancer above or eipAllocations below. I'd probably choose the eipAllocations

deads2k · 2024-04-22T15:52:03Z

operator/v1/types_ingress.go

@@ -634,7 +636,9 @@ type AWSClassicLoadBalancerParameters struct {

 // AWSNetworkLoadBalancerParameters holds configuration parameters for an
 // AWS Network load balancer.
+// +openshift:enable:FeatureGate=SetEIPForNLBIngressController


Gate the field, not the type. Then this will generator correctly.

deads2k · 2024-04-22T15:52:15Z

operator/v1/types_ingress.go

 type AWSNetworkLoadBalancerParameters struct {
+	EIPAllocations []configv1.EIPAllocations `json:"eipAllocations,omitempty"`


need godoc on the field

miheer · 2024-04-24T00:55:47Z

@deads2k I am still getting this issue after running make verify as mentioned in #1826 (comment) :

Found untracked file 0000_10_config-operator_01_ingresses.crd.yaml in payload CRD manifests. Please add the file to crd_globs in hack/update-payload-crds.sh. make: *** [verify-scripts] Error 1 misalunk@misalunk-mac api %

Miciah · 2024-04-25T04:29:30Z

config/v1/tests/ingresses.config.openshift.io/SetEIPForNLBIngressController.yaml

+crdName: ingresses.config.openshift.io
+tests:


The integration job failed, and it looks like the reason is that it is running these tests for the "Default" featureset. Try adding the following to this file:

featureGate: SetEIPForNLBIngressController

…s Controller to set EIP via installer and Ingress Controller `config/v1/types_ingress.go` - Adds an API field `eip-allocations` in the cluster ingress config object whose value is set by the installer using install-config.yaml `operator/v1/types_ingress.go` - Adds an API field `eip-allocations` in the Ingress Controller CR object using which the Ingress Operator scales an Ingress Controller with service type balancer whose annotation `service.beta.kubernetes.io/aws-load-balancer-eip-allocations` is set by the value of the field `eip-allocations` of the Ingress Controller. Epic: https://issues.redhat.com/browse/NE-1274 Story: https://issues.redhat.com/browse/NE-1516

openshift-ci · 2024-04-25T10:29:57Z

@miheer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	`24253ce`	link	true	`/test e2e-aws-ovn-hypershift`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

candita · 2024-04-26T17:13:32Z

config/v1/types_ingress.go

 }

+// AWSNetworkLoadBalancerParameters holds configuration parameters for an
+// AWS Network load balancer. For Example: Setting AWS EIPs https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html
+type AWSNetworkLoadBalancerParameters struct {


@miheer we already have an identical type in https://github.com/openshift/api/blob/master/operator/v1/types_ingress.go#L516. Can we choose one or the other?

@Miciah let me know that we need both of these, but there may be a way to not declare them twice.

They are two different APIs. So, we can't.

candita · 2024-04-26T17:35:46Z

config/v1/types_ingress.go

+type AWSNetworkLoadBalancerParameters struct {
+	// You can assign Elastic IP addresses to the Network Load Balancer by adding the following annotation.
+	// The number of Allocation IDs must match the number of subnets that are used for the load balancer.
+	// service.beta.kubernetes.io/aws-load-balancer-eip-allocations: eipalloc-xxxxxxxxxxxxxxxxx,eipalloc-yyyyyyyyyyyyyyyyy


Must the EIP allocation ids have eipalloc- prefix? Any other restrictions on formatting, length, or uniqueness?

The annotation should not be mentioned at all.

candita · 2024-04-26T17:37:10Z

config/v1/types_ingress.go

+	// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html
+	// https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/guide/service/annotations/#eip-allocations
+	// +openshift:enable:FeatureGate=SetEIPForNLBIngressController
+	EIPAllocations []EIPAllocations `json:"eipAllocations"`


Consider adding a maximum slice length, and enforce with CEL.

No need for CEL; just use +kubebuilder:validation:MaxItems.

candita · 2024-04-26T17:44:20Z

config/v1/types_ingress.go

+	// You can assign Elastic IP addresses to the Network Load Balancer by adding the following annotation.
+	// The number of Allocation IDs must match the number of subnets that are used for the load balancer.
+	// service.beta.kubernetes.io/aws-load-balancer-eip-allocations: eipalloc-xxxxxxxxxxxxxxxxx,eipalloc-yyyyyyyyyyyyyyyyy
+	// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html


I would not point people to this AWS url unless we support all of the actions described there. Just summarize the parts our users need to know.

E.g., do we support "Associate an Elastic IP address with an instance or network interface"?

Providing a URL is fine, but only if the godoc explains why a URL is mentioned. If you tell me a URL but don't tell me why you told me that URL, I will ignore it. For example, you can say something like, "See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html for general information about configuration, characteristics, and limitations of Elastic IP addresses."

Agreed, but if this AWS url ends up in OpenShift docs, I predict it will cause more questions than it answers.

I think it is fine to reference the AWS documentation if it is relevant. We already reference it here:

api/operator/v1/types_ingress.go

Lines 513 to 535 in 8203151

// AWSLoadBalancerParameters provides configuration settings that are

// specific to AWS load balancers.

// +union

type AWSLoadBalancerParameters struct {

// type is the type of AWS load balancer to instantiate for an ingresscontroller.

//

// Valid values are:

//

// * "Classic": A Classic Load Balancer that makes routing decisions at either

// the transport layer (TCP/SSL) or the application layer (HTTP/HTTPS). See

// the following for additional details:

//

// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#clb

//

// * "NLB": A Network Load Balancer that makes routing decisions at the

// transport layer (TCP/SSL). See the following for additional details:

//

// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#nlb

//

// +unionDiscriminator

// +kubebuilder:validation:Required

// +required

Type AWSLoadBalancerType `json:"type"`

There are also references to documentation on amazon.com in the Machine API, Ingress config API, DNS config API, and Infrastructure config API, and there are references to alibabacloud.com, cloud.google.com, cloud.ibm.com, docker.com, kubernetes.io and k8s.io, microsoft.com, mozilla.com, and vmware.com documentation throughout OpenShift API definitions. It makes sense to be judicious about linking to non-Red Hat documentation, but as an integrator, we inevitably need to reference external documentation.

Miciah · 2024-04-26T19:56:16Z

config/v1/types_ingress.go

+// AWSNetworkLoadBalancerParameters holds configuration parameters for an
+// AWS Network load balancer. For Example: Setting AWS EIPs https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html
+type AWSNetworkLoadBalancerParameters struct {
+	// You can assign Elastic IP addresses to the Network Load Balancer by adding the following annotation.


The whole point of this API is the the cluster-admin should not use the annotation.

Miciah · 2024-04-26T19:57:02Z

config/v1/types_ingress.go

+	// The number of Allocation IDs must match the number of subnets that are used for the load balancer.
+	// service.beta.kubernetes.io/aws-load-balancer-eip-allocations: eipalloc-xxxxxxxxxxxxxxxxx,eipalloc-yyyyyyyyyyyyyyyyy
+	// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html
+	// https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/guide/service/annotations/#eip-allocations


The aws-load-balancer-controller documentation is irrelevant; ELBs for ingresscontrollers are handled by cloud-controller-manager and cloud-provider-aws. Please avoid linking to the aws-load-balancer-controller documentation as it has been the source of much confusion in the past.

Miciah · 2024-04-26T19:57:48Z

config/v1/types_ingress.go

+	EIPAllocations []EIPAllocations `json:"eipAllocations"`
+}
+
+type EIPAllocations string


This definition is still missing godoc.

Miciah · 2024-04-26T19:58:33Z

config/v1/types_ingress.go

@@ -151,8 +152,28 @@ type AWSIngressSpec struct {
 	// +kubebuilder:validation:Enum:=NLB;Classic
 	// +kubebuilder:validation:Required
 	Type AWSLBType `json:"type,omitempty"`
+
+	// networkLoadBalancerParameters holds configuration parameters for an AWS
+	// network load balancer. Present only if type is NLB.


Please capitalize "Network Load Balancer" correctly here and elsewhere.

Suggested change

// network load balancer. Present only if type is NLB.

// Network Load Balancer. This field is present only if the type field is set to NLB.

That might be a general use of the phrase "network load balancer", which I saw alot in the EP. If it is an object, it should be networkLoadBalancer, all one word, right?

If the phrase is used in the general sense, then it needs to be defined. I know what a "load balancer" is, but I don't know what a "network load balancer" is (or why the distinction would be relevant here), so I assumed that Miheer meant "Network Load Balancer" (AKA NLB).

Miciah · 2024-04-26T20:00:37Z

operator/v1/types_ingress.go

@@ -544,7 +546,7 @@ type AWSLoadBalancerParameters struct {
 	// network load balancer. Present only if type is NLB.
 	//
 	// +optional
-	NetworkLoadBalancerParameters *AWSNetworkLoadBalancerParameters `json:"networkLoadBalancer,omitempty"`
+	NetworkLoadBalancerParameters *AWSNetworkLoadBalancerParameters `json:"nlbParameters,omitempty"`


This API field is already in released versions of OpenShift. You cannot change the field name.

Oh, that's my fault. I asked for this change. Sorry @miheer.

gcs278 · 2024-05-08T03:55:46Z

config/v1/types_ingress.go

+	// https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html
+	// https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.7/guide/service/annotations/#eip-allocations
+	// +openshift:enable:FeatureGate=SetEIPForNLBIngressController
+	EIPAllocations []EIPAllocations `json:"eipAllocations"`


I think you are going to get pinged by API team on not having // +listType=<type> tag. See https://github.com/kubernetes/kube-openapi/blob/master/pkg/idl/doc.go. Atomic is generally safe bet.

@JoelSpeed can confirm.

This is a list of strings, I assume each item in the list should be unique right? Will the list have one actor or multiple? I think we probably want this to be atomic and to enforce uniqueness using CEL

Thinking about this which caused issues before with the set listType

gcs278 · 2024-05-08T04:01:54Z

operator/v1/types_ingress.go

@@ -633,8 +635,15 @@ type AWSClassicLoadBalancerParameters struct {
 }

 // AWSNetworkLoadBalancerParameters holds configuration parameters for an
-// AWS Network load balancer.
+// AWS Network load balancer. For Example: Setting AWS EIPs https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/elastic-ip-addresses-eip.html


This "for example" and including a link seems quite odd to me for this type of GO doc. We don't list examples in AWSClassicLoadBalancerParameters. It seems a bit inconsistent.

gcs278 · 2024-05-08T04:17:42Z

config/v1/types_ingress.go

+	EIPAllocations []EIPAllocations `json:"eipAllocations"`
+}
+
+type EIPAllocations string


Calling this the same name as the field type is confusing to me. I don't think this should be plural, it is a singular EIPAllocation.

Suggested change

type EIPAllocations string

type EIPAllocation string

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 23, 2024

openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 23, 2024

openshift-ci bot requested review from knobunc and mfojtik March 23, 2024 01:13

miheer force-pushed the eip branch from c86c0b2 to ed72b77 Compare March 23, 2024 10:16

deads2k reviewed Mar 25, 2024

View reviewed changes

openshift-ci bot assigned Miciah Mar 27, 2024

miheer force-pushed the eip branch from ed72b77 to 191f0ad Compare March 30, 2024 11:55

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2024

openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 30, 2024

miheer force-pushed the eip branch from 191f0ad to 41914f9 Compare March 30, 2024 14:13

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2024

miheer force-pushed the eip branch 2 times, most recently from a8e5e98 to f6536ae Compare April 1, 2024 03:24

miheer force-pushed the eip branch from f6536ae to dd987ff Compare April 9, 2024 05:14

miheer mentioned this pull request Apr 16, 2024

NE-1517: Set EIP for NLB Ingress controller. openshift/enhancements#1593

Open

miheer force-pushed the eip branch from dd987ff to 261093f Compare April 17, 2024 14:30

gcs278 mentioned this pull request Apr 17, 2024

NE-705: IngressController subnet selection in AWS openshift/enhancements#1595

Open

deads2k reviewed Apr 18, 2024

View reviewed changes

miheer force-pushed the eip branch from 261093f to fed2be6 Compare April 22, 2024 15:21

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024

deads2k reviewed Apr 22, 2024

View reviewed changes

miheer force-pushed the eip branch from fed2be6 to ad7df5f Compare April 23, 2024 23:32

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

miheer force-pushed the eip branch from ad7df5f to 96011d8 Compare April 23, 2024 23:35

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

miheer force-pushed the eip branch 3 times, most recently from 41c7cea to 194ad66 Compare April 25, 2024 04:05

Miciah reviewed Apr 25, 2024

View reviewed changes

miheer force-pushed the eip branch from 194ad66 to 7be17c6 Compare April 25, 2024 05:55

miheer force-pushed the eip branch from 7be17c6 to 24253ce Compare April 25, 2024 07:32

candita reviewed Apr 26, 2024

View reviewed changes

Miciah reviewed Apr 26, 2024

View reviewed changes

Miciah mentioned this pull request Apr 28, 2024

NE-1674 : Adds logic to add service annotation service.beta.kubernetes.io/aws-load-balancer-eip-allocations openshift/cluster-ingress-operator#1034

Open

gcs278 reviewed May 8, 2024

View reviewed changes

		}

		// AWSNetworkLoadBalancerParameters holds configuration parameters for an

		type AWSNetworkLoadBalancerParameters struct {
		EIPAllocations []configv1.EIPAllocations `json:"eipAllocations,omitempty"`

	// AWSLoadBalancerParameters provides configuration settings that are
	// specific to AWS load balancers.
	// +union
	type AWSLoadBalancerParameters struct {
	// type is the type of AWS load balancer to instantiate for an ingresscontroller.
	//
	// Valid values are:
	//
	// * "Classic": A Classic Load Balancer that makes routing decisions at either
	// the transport layer (TCP/SSL) or the application layer (HTTP/HTTPS). See
	// the following for additional details:
	//
	// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#clb
	//
	// * "NLB": A Network Load Balancer that makes routing decisions at the
	// transport layer (TCP/SSL). See the following for additional details:
	//
	// https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#nlb
	//
	// +unionDiscriminator
	// +kubebuilder:validation:Required
	// +required
	Type AWSLoadBalancerType `json:"type"`

	// network load balancer. Present only if type is NLB.
	// Network Load Balancer. This field is present only if the type field is set to NLB.

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller #1826

Are you sure you want to change the base?

NE-1516: Adds a field in the cluster ingress config object and Ingress Controller to set EIP via installer and Ingress Controller #1826

Conversation

miheer commented Mar 23, 2024 • edited

openshift-ci-robot commented Mar 23, 2024 • edited by openshift-ci bot

openshift-ci bot commented Mar 23, 2024

openshift-ci bot commented Mar 23, 2024

openshift-ci-robot commented Mar 23, 2024 • edited by openshift-ci bot

deads2k Mar 25, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miheer Mar 27, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

candita commented Mar 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miheer commented Apr 24, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Apr 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

candita Apr 26, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Miciah Apr 26, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miheer commented Mar 23, 2024 •

edited

openshift-ci-robot commented Mar 23, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Mar 23, 2024 •

edited by openshift-ci bot

deads2k Mar 25, 2024 •

edited

miheer Mar 27, 2024 •

edited

candita Apr 26, 2024 •

edited

Miciah Apr 26, 2024 •

edited