OCPCLOUD-2563: Add Machine/MachineSet API for MAPI to CAPI migration

[JoelSpeed]

This implements the first part of the API from openshift/enhancements#1465.

This adds a new authoritativeAPI field to the Machine and MachineSet spec and status, which will allow our new project to determine which of the two backends should be implementing the functionality of the machines.

The feature will be behing the MachineAPIMigration feature gate. Not adding this to TechPreview until we have got something to show for the project, likely in 4.17.

[openshift-ci-robot]

@JoelSpeed: This pull request references OCPCLOUD-2563 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

This implements the first part of the API from openshift/enhancements#1465.

This adds a new authoritativeAPI field to the Machine and MachineSet spec and status, which will allow our new project to determine which of the two backends should be implementing the functionality of the machines.

The feature will be behing the MachineAPIMigration feature gate. Not adding this to TechPreview until we have got something to show for the project, likely in 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

These were in the base set of test files, but other platforms have their own test file, so, pulled these out

[JoelSpeed]

/hold until @deads2k can review

[theobarberbany]

/retest

[theobarberbany]

LGTM at first pass.

The Machine API Test files changes are unrelated to this change, right? Just a result of the new way that featuregates are being done?

[JoelSpeed]

The Machine API Test files changes are unrelated to this change, right? Just a result of the new way that featuregates are being done?

When adding feature gated fields, the generators now generate various feature gate versions of each CRD. Each CRD is required to have a test suite file, so I had to add them as I'm the first one putting a feature gated field on some of these resources

[nrb]

I take it you're omitting MachineHealthCheck and ControlPlaneMachineSet here on purpose?

[JoelSpeed]

I take it you're omitting MachineHealthCheck and ControlPlaneMachineSet here on purpose?

Yes, my intention is that we build out the Machine and MachineSet core functionality for this feature first, and then once we have made progress on those, start looking more at the extensions like MHC and CPMS

[JoelSpeed]

/test integration

Change was a global timeout hit, not related to this PR

[theobarberbany]

I attempted to rebase this, then got confused as we are part way through changing how tests work (feature gates, files moving around).

I don't think this is a blocker yet on our work so I have reverted to how Joel left it.

New docs in https://github.com/openshift/api/pull/1834/files

[theobarberbany]

🤞 for getting this rebase right, this time

[theobarberbany]

That's a fun bug in the bot 😂

All CI failing : Terminal error: nonretryable error: no build client found for cluster "build03".

CI Bot: all tests passed!

[JoelSpeed]

@deads2k Additional transitional validations added and tests for enum and transitions as well

[deads2k]

I'll trust that there's a test for this.

[JoelSpeed]

There are 8 for Machine and 8 for MachineSet specifically testing this rule

[deads2k]

intentionally never enabled?

[JoelSpeed]

Yes. As this is greenfield, there's a lot to build before we have something that works. My hope was that we can get this all set up to a point where there's actually something tangible before adding to a feature set some time in 4.17

[deads2k]

/lgtm
/hold for the team to make their judgement as well.

[JoelSpeed]

Small update to fix a typo, and then added a fieldPath and reason for the CEL preventing reduction of the synchronizedGeneration. Seems to me that it should be a Forbidden so I've updated that. Cosmetic change really.

I've also got a PR up for the generator to add the fieldPath and reason as a first class thing, so fingers crossed can drop the manual overrides in the future

[theobarberbany]

Tests and validations look good to me!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-hypershift	d3739e0	link	true	/test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.