Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(k8s): update k8s to v1.30 #1813

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dinhxuanvu
Copy link
Member

No description provided.

Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

Hello @dinhxuanvu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@dinhxuanvu dinhxuanvu changed the title bump(k8s): update k8s to v1.30 [WIP] bump(k8s): update k8s to v1.30 Mar 15, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
@dinhxuanvu
Copy link
Member Author

The PR is rebased on 1.30 beta release at the monent.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2024
@openshift-ci openshift-ci bot requested review from bparees and soltysh March 15, 2024 17:45
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dinhxuanvu
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dinhxuanvu
Copy link
Member Author

dinhxuanvu commented Mar 28, 2024

Updated to 1.30.0-rc.0
Will squash commits later. For now, keeping separate commits for review purposes.

@soltysh
Copy link
Member

soltysh commented Apr 17, 2024

/test unit

@soltysh
Copy link
Member

soltysh commented Apr 18, 2024

/test unit

1 similar comment
@hongkailiu
Copy link
Member

/test unit

@dinhxuanvu dinhxuanvu changed the title [WIP] bump(k8s): update k8s to v1.30 bump(k8s): update k8s to v1.30 Apr 18, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2024
@dinhxuanvu dinhxuanvu force-pushed the rebase-1.30 branch 2 times, most recently from 3f13d95 to cdf4fdc Compare April 19, 2024 03:17
@soltysh
Copy link
Member

soltysh commented Apr 19, 2024

/hold
this should not merge into 4.16 accidentally

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2024
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Copy link
Contributor

openshift-ci bot commented Apr 20, 2024

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 125eed1 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants