Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add InPlacePodVerticalScaling featuregate (TechPreviewNoUpgrade) #1782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joelsmith
Copy link

@joelsmith joelsmith commented Mar 6, 2024

This feature allows a pod spec's resource requests and limits to be modified, and is an important upcoming feature for Vertical Pod Autoscaler to be able to modify pods without evicting and replacing them.

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

Hello @joelsmith! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 6, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and knobunc March 6, 2024 05:56
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: joelsmith
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joelsmith
Copy link
Author

/retest

@JoelSpeed
Copy link
Contributor

Changes look good, just for my own understanding, can you answer the following please.

What is the status of this featuregate upstream?

Can you confirm in which version it's introduced and whether it's been moved to beta yet?

Is there a plan for when it will be moved to GA?

@joelsmith
Copy link
Author

Here is the upstream KEP:

kubernetes/enhancements#1287

Changes look good, just for my own understanding, can you answer the following please.

What is the status of this featuregate upstream?

Disabled by default, and expected to remain so for a few versions. The plan is for it to be alpha also in v1.30

Can you confirm in which version it's introduced and whether it's been moved to beta yet?

It was added in v1.27, and won't be moved to beta until v1.31 at the earliest.

Is there a plan for when it will be moved to GA?

The KEP currently says past 1.32, so probably no earlier than 1.33.

/retest

@JoelSpeed
Copy link
Contributor

/retest

@joelsmith joelsmith force-pushed the master branch 2 times, most recently from d020f31 to 64dd402 Compare March 10, 2024 02:55
@joelsmith
Copy link
Author

/retest

1 similar comment
@JoelSpeed
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2024
@joelsmith
Copy link
Author

/retest

2 similar comments
@joelsmith
Copy link
Author

/retest

@joelsmith
Copy link
Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2024
@joelsmith
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 6, 2024

@joelsmith: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 0b9cbf6 link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelsmith
Copy link
Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants