New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InPlacePodVerticalScaling featuregate (TechPreviewNoUpgrade) #1782
base: master
Are you sure you want to change the base?
Conversation
Hello @joelsmith! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joelsmith The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Changes look good, just for my own understanding, can you answer the following please. What is the status of this featuregate upstream? Can you confirm in which version it's introduced and whether it's been moved to beta yet? Is there a plan for when it will be moved to GA? |
Here is the upstream KEP:
Disabled by default, and expected to remain so for a few versions. The plan is for it to be alpha also in v1.30
It was added in v1.27, and won't be moved to beta until v1.31 at the earliest.
The KEP currently says past 1.32, so probably no earlier than 1.33. /retest |
/retest |
d020f31
to
64dd402
Compare
/retest |
1 similar comment
/retest |
/retest |
2 similar comments
/retest |
/retest |
/retest |
@joelsmith: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This feature allows a pod spec's resource requests and limits to be modified, and is an important upcoming feature for Vertical Pod Autoscaler to be able to modify pods without evicting and replacing them.