OCPCLOUD-2561: Remove CloudProviderExternal feature gates

[JoelSpeed]

These feature gates were promoted to GA in 4.15, the code that observes them was in library go and vendored into 4 other operators, once the following 4 PRs are merged, we no longer require these feature gates

• OCPCLOUD-2514: Remove reliance on feature gates for whether to deploy CCMs cluster-cloud-controller-manager-operator#334
• OCPCLOUD-2514: External CCM should no longer rely on feature gate access cluster-kube-apiserver-operator#1649
• OCPCLOUD-2514: Remove reliance on Cloud Provider feature gates for determining if CCM should be deployed. cluster-kube-controller-manager-operator#794
• OCPCLOUD-2514,OCPCLOUD-2516: Remove reliance on feature gates for cloud provider flags machine-config-operator#4228

[openshift-ci-robot]

@JoelSpeed: This pull request references OCPCLOUD-2514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

These feature gates were promoted to GA in 4.15, the code that observes them was in library go and vendored into 4 other operators, once the following 4 PRs are merged, we no longer require these feature gates

• OCPCLOUD-2514: Remove reliance on feature gates for whether to deploy CCMs cluster-cloud-controller-manager-operator#334
• OCPCLOUD-2514: External CCM should no longer rely on feature gate access cluster-kube-apiserver-operator#1649
• OCPCLOUD-2514: Remove reliance on Cloud Provider feature gates for determining if CCM should be deployed. cluster-kube-controller-manager-operator#794
• OCPCLOUD-2514,OCPCLOUD-2516: Remove reliance on feature gates for cloud provider flags machine-config-operator#4228

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

Per conversation in slack, holding this until further notice (perhaps 4.18 open)

/hold

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@JoelSpeed: This pull request references OCPCLOUD-2561 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

These feature gates were promoted to GA in 4.15, the code that observes them was in library go and vendored into 4 other operators, once the following 4 PRs are merged, we no longer require these feature gates

• OCPCLOUD-2514: Remove reliance on feature gates for whether to deploy CCMs cluster-cloud-controller-manager-operator#334
• OCPCLOUD-2514: External CCM should no longer rely on feature gate access cluster-kube-apiserver-operator#1649
• OCPCLOUD-2514: Remove reliance on Cloud Provider feature gates for determining if CCM should be deployed. cluster-kube-controller-manager-operator#794
• OCPCLOUD-2514,OCPCLOUD-2516: Remove reliance on feature gates for cloud provider flags machine-config-operator#4228

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-techpreview	ee8ab17	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial	ee8ab17	link	true	/test e2e-aws-serial
ci/prow/e2e-upgrade-minor	ee8ab17	link	true	/test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.