Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-25821: add MCO management of api-int CA #1718

Closed
wants to merge 1 commit into from

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Jan 8, 2024

the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.

What I did here is

  • add KubeAPIServerClientCA to represent what was previously being stored in KubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity.
  • made KubeAPIServerServingCAData store the data for the api-int CA

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 8, 2024
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

Hello @cdoern! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2024
Copy link
Contributor

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cdoern
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 9, 2024
@cdoern
Copy link
Contributor Author

cdoern commented Jan 10, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 10, 2024
@openshift-ci-robot
Copy link

@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Charlie Doern <cdoern@redhat.com>
@openshift-ci-robot
Copy link

@cdoern: This pull request references Jira Issue OCPBUGS-25821, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

In response to this:

the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.

What I did here is

  • add KubeAPIServerClientCA to represent what was previously being stored in KubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity.
  • made KubeAPIServerServingCAData store the data for the api-int CA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

@cdoern: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure fd7da99 link false /test e2e-azure
ci/prow/e2e-upgrade fd7da99 link true /test e2e-upgrade
ci/prow/integration bc13c17 link true /test integration
ci/prow/e2e-upgrade-minor bc13c17 link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yuqi-zhang
Copy link
Contributor

/close

We're going to close this and not do this management with an API process for now so its no longer attached to the bug. We'll revisit in newer versions

@openshift-ci openshift-ci bot closed this May 6, 2024
Copy link
Contributor

openshift-ci bot commented May 6, 2024

@yuqi-zhang: Closed this PR.

In response to this:

/close

We're going to close this and not do this management with an API process for now so its no longer attached to the bug. We'll revisit in newer versions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@cdoern: This pull request references Jira Issue OCPBUGS-25821. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

the MCO needs to add some support for long living certs (10 years) that get populated in /etc/kubernetes/kubeconfig. These certs come from the openshift-config-managed/kube-apiserver-server-ca configmap and currently are only applied on bootstrap. So, if a cluster rotates often or exists for a long period of time, a user will eventually run into the "certificate signed by unknown authority" error when these certs expire.

What I did here is

  • add KubeAPIServerClientCA to represent what was previously being stored in KubeAPIServerServingCAData. We were storing the client-ca data in the serverca entity.
  • made KubeAPIServerServingCAData store the data for the api-int CA

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants