Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Upload translog checkpoint as object metadata to translog #13637

Merged
merged 15 commits into from
May 23, 2024

Conversation

skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented May 13, 2024

Previous PR link: #13272

Description

This PR is a sub task of feature request #13022. And is being tracked here #13091.

This PR include below changes -

  1. We introduced a new key (translog-metadata) in remote store custom metadata for new indices.
  2. For the indices having translog-metadata as true, the translog.ckp file's data is now stored as object metadata associated with the translog.tlog file when uploading to an S3 remote storage.
  3. We will make only one download calls for translog.tlog file with it's metadata to recover translog files for a generation.
  4. Handling of translog file deletion calls.

Related Issues

Resolves #13094

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Performance Storage:Remote v2.14.0 labels May 13, 2024
@skumawat2025 skumawat2025 self-assigned this May 13, 2024
Copy link
Contributor

❌ Gradle check result for c20ae47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 changed the title initial commits Translog Optimisation May 13, 2024
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❌ Gradle check result for 6724043: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for b07035e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❌ Gradle check result for fc368da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7586b7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❕ Gradle check result for ccd7ebf: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@skumawat2025 skumawat2025 force-pushed the method02 branch 2 times, most recently from eab4d20 to 52fc7ad Compare May 22, 2024 11:14
Copy link
Contributor

✅ Gradle check result for e2a0329: SUCCESS

Copy link
Contributor

✅ Gradle check result for eab4d20: SUCCESS

Copy link
Contributor

✅ Gradle check result for 52fc7ad: SUCCESS

Copy link
Contributor

✅ Gradle check result for 5e2d0b0: SUCCESS

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

❌ Gradle check result for c799a7a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025
Copy link
Contributor Author

❌ Gradle check result for c799a7a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky: #11547
Flaky: #5425

Copy link
Contributor

✅ Gradle check result for c2fe637: SUCCESS

Copy link
Contributor

❌ Gradle check result for b9731fa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Copy link
Contributor

✅ Gradle check result for 88e6e27: SUCCESS

@sachinpkale sachinpkale changed the title [Remote Store] Upload translog checkpoint as object metadata to translog.tlog [Remote Store] Upload translog checkpoint as object metadata to translog May 23, 2024
@sachinpkale sachinpkale merged commit 76e2a5d into opensearch-project:main May 23, 2024
30 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13637-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 76e2a5d9d70ab310033f33151fdaa0ab68c6537e
# Push it to GitHub
git push --set-upstream origin backport/backport-13637-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13637-to-2.x.

skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 23, 2024
…log (opensearch-project#13637)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 23, 2024
…log (opensearch-project#13637)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
sachinpkale pushed a commit that referenced this pull request May 23, 2024
…log (#13637) (#13795)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Storage:Performance Storage:Remote v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
5 participants