Fix parseToken array popping #13620
Fix parseToken array popping #13620
Conversation
Signed-off-by: naomichi-y <n.yamakita@gmail.com>
Signed-off-by: naomichi-y <n.yamakita@gmail.com>
|
❌ Gradle check result for 51d6d10: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3862517: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Naomichi Yamakita <n.yamakita@gmail.com>
|
@msfroh |
|
❌ Gradle check result for fe60f0d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Naomichi Yamakita <n.yamakita@gmail.com>
Signed-off-by: Naomichi Yamakita <n.yamakita@gmail.com>
|
❌ Gradle check result for c3adeb4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 7f7ee10: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
naomichi-y
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
| @@ -74,8 +74,7 @@ public XContentParser parseObject() throws IOException { | |||
| return JsonXContent.jsonXContent.createParser(this.xContentRegistry, this.deprecationHandler, String.valueOf(jString)); | |||
| } | |||
|
|
|||
| private void parseToken(StringBuilder path, String currentFieldName) throws IOException { | |||
|
|
|||
| private void parseToken(StringBuilder path, String currentFieldName, boolean popName) throws IOException { | |||
There was a problem hiding this comment.
Thanks for the fix @naomichi-y , do you think we could refactor the method to use just Stack<String> to collect the current path instead of StringBuffer + boolean flag manipulation? (to be fair, it is pretty difficult to follow the current implementation and it is becoming even more complicated). Thank you.
There was a problem hiding this comment.
@reta
I looked into the code a bit, and it seems that removing popName might be difficult.
The parseToken method parses the JSON recursively and removes trailing hierarchies from the field names depending on the type of the parent token.
However, I haven't been able to read the original code in its entirety, and I'm not very familiar with Java, so I might be misunderstanding something...
Description
Fixed an issue in the flat_object where array field names were incorrectly removed after processing the first object, leading to inaccurate key-paths in flattened JSON data.
Related Issues
#13351
Check List
New functionality has been documented.New functionality has javadoc addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.