New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance tika document parsing tests #13618

Merged

reta merged 7 commits into opensearch-project:main from finnegancarroll:tika_tests

May 16, 2024

Contributor

finnegancarroll commented May 9, 2024 •

edited by reta

Description

Enhance tika document parsing tests by validating output against current version.

Related Issues

Resolves "Improve the validation on TikaDocTests #12887"

Check List

New functionality includes testing.
- All tests pass
~~New functionality has been documented.~~
- ~~New functionality has javadoc added~~
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
~~Commit changes are listed out in CHANGELOG.md file (See: Changelog)~~
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

finnegancarroll requested review from anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami, tlfeng and VachaShah as code owners

May 9, 2024 22:38

Contributor

github-actions bot commented May 9, 2024

❌ Gradle check result for 7ee6045: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

finnegancarroll marked this pull request as draft

May 10, 2024 00:00

finnegancarroll changed the title ~~Draft: Tika tests~~ Tika tests

Contributor

github-actions bot commented May 10, 2024

❌ Gradle check result for 810f3a9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor Author

finnegancarroll commented May 10, 2024

Gradle check failing due to unrelated flaky test: #11979

Contributor

github-actions bot commented May 10, 2024

❌ Gradle check result for 810f3a9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

finnegancarroll force-pushed the tika_tests branch from 2dc3fcf to ddd4b56 Compare

May 10, 2024 23:03

Contributor

github-actions bot commented May 10, 2024

❌ Gradle check result for 3bd9469: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented May 10, 2024

❌ Gradle check result for 2dc3fcf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta reviewed

View reviewed changes

plugins/ingest-attachment/src/test/java/org/opensearch/ingest/attachment/TikaDocTests.java Outdated Show resolved Hide resolved

Contributor

github-actions bot commented May 14, 2024

❌ Gradle check result for 3fcc4bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor Author

finnegancarroll commented May 14, 2024

Known flaky test: #13600

Contributor

github-actions bot commented May 15, 2024

❌ Gradle check result for 3fcc4bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

finnegancarroll force-pushed the tika_tests branch from 9ae651e to ef62853 Compare

May 15, 2024 16:37

Contributor

github-actions bot commented May 15, 2024

❌ Gradle check result for 9ae651e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented May 15, 2024

❌ Gradle check result for ef62853: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Collaborator

reta commented May 15, 2024

❌ Gradle check result for ef62853: FAILURE

Needs #13673

Collaborator

reta commented May 15, 2024

@finnegancarroll we sadly have pretty flaky test suite now, fe this combination fails for me:

./gradlew ':plugins:ingest-attachment:test' --tests "org.opensearch.ingest.attachment.TikaDocTests.testParseSamples" -Dtests.seed=98D53194946B5C85 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=hi-IN -Dtests.timezone=Asia/Istanbul

Please let ./gradlew :plugins:ingest-attachment:check run for a couple of hours, to make sure the test suite is stable, thank you.

finnegancarroll added 7 commits

May 15, 2024 17:00


          Update tika document parsing bwc tests.

fdfcce5

Signed-off-by: Carroll <carrofin@amazon.com>


          Skip sample tika files which do not parse consistently.

df798f3

Signed-off-by: Carroll <carrofin@amazon.com>


          Formatting for spotlessJavaCheck.

982ac9c

Signed-off-by: Carroll <carrofin@amazon.com>


          Use fixed locale for consistent tika parsing.

971d298

Signed-off-by: Carroll <carrofin@amazon.com>


          Move sha1 map to .checksums file.

ef4dcb8

Signed-off-by: Carroll <carrofin@amazon.com>


          For locale dependant files do not verify contents with hash.

1b2d46c

Signed-off-by: Carroll <carrofin@amazon.com>


          Remove strict checksum validation for additional locale dependant files.

f0cc854

Signed-off-by: Carroll <carrofin@amazon.com>

finnegancarroll force-pushed the tika_tests branch from ef62853 to f0cc854 Compare

May 16, 2024 00:02

Contributor

github-actions bot commented May 16, 2024

✅ Gradle check result for f0cc854: SUCCESS

codecov bot commented May 16, 2024 •

edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.56%. Comparing base (b15cb0c) to head (f0cc854).
Report is 286 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13618      +/-   ##
============================================
+ Coverage     71.42%   71.56%   +0.14%     
- Complexity    59978    61201    +1223     
============================================
  Files          4985     5059      +74     
  Lines        282275   287522    +5247     
  Branches      40946    41646     +700     
============================================
+ Hits         201603   205759    +4156     
- Misses        63999    64777     +778     
- Partials      16673    16986     +313

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Contributor Author

finnegancarroll commented May 16, 2024

Removed strict checksum validation for some additional files with locale dependent parsing. Ran for a couple hours and with all available locales in Locale.getAvailableLocales() to ensure no flaky cases remain.

dblock approved these changes

View reviewed changes

Member

dblock left a comment

This looks better than what we have, @reta any objections?

Collaborator

reta commented May 16, 2024

This looks better than what we have, @reta any objections?

It really does, no objections @dblock , just double checking no flakyness is going to be introduced

Member

dblock commented May 16, 2024

This looks better than what we have, @reta any objections?

It really does, no objections @dblock , just double checking no flakyness is going to be introduced

Thanks. All yours to merge.

reta approved these changes

View reviewed changes

reta added the backport 2.x label

reta merged commit f217270 into opensearch-project:main

32 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Enhance tika document parsing tests (#13618)

876d22a

* Update tika document parsing bwc tests.

Signed-off-by: Carroll <carrofin@amazon.com>

* Skip sample tika files which do not parse consistently.

Signed-off-by: Carroll <carrofin@amazon.com>

* Formatting for spotlessJavaCheck.

Signed-off-by: Carroll <carrofin@amazon.com>

* Use fixed locale for consistent tika parsing.

Signed-off-by: Carroll <carrofin@amazon.com>

* Move sha1 map to .checksums file.

Signed-off-by: Carroll <carrofin@amazon.com>

* For locale dependant files do not verify contents with hash.

Signed-off-by: Carroll <carrofin@amazon.com>

* Remove strict checksum validation for additional locale dependant files.

Signed-off-by: Carroll <carrofin@amazon.com>

---------

Signed-off-by: Carroll <carrofin@amazon.com>
(cherry picked from commit f217270)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Enhance tika document parsing tests #13708

Merged

reta pushed a commit that referenced this pull request


          Enhance tika document parsing tests (#13618) (#13708)

90265f3

* Update tika document parsing bwc tests.



* Skip sample tika files which do not parse consistently.



* Formatting for spotlessJavaCheck.



* Use fixed locale for consistent tika parsing.



* Move sha1 map to .checksums file.



* For locale dependant files do not verify contents with hash.



* Remove strict checksum validation for additional locale dependant files.



---------


(cherry picked from commit f217270)

Signed-off-by: Carroll <carrofin@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request


          Enhance tika document parsing tests (opensearch-project#13618)

b65f5e4

* Update tika document parsing bwc tests.

Signed-off-by: Carroll <carrofin@amazon.com>

* Skip sample tika files which do not parse consistently.

Signed-off-by: Carroll <carrofin@amazon.com>

* Formatting for spotlessJavaCheck.

Signed-off-by: Carroll <carrofin@amazon.com>

* Use fixed locale for consistent tika parsing.

Signed-off-by: Carroll <carrofin@amazon.com>

* Move sha1 map to .checksums file.

Signed-off-by: Carroll <carrofin@amazon.com>

* For locale dependant files do not verify contents with hash.

Signed-off-by: Carroll <carrofin@amazon.com>

* Remove strict checksum validation for additional locale dependant files.

Signed-off-by: Carroll <carrofin@amazon.com>

---------

Signed-off-by: Carroll <carrofin@amazon.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

reta reta approved these changes

dblock dblock approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

dreamer-89 Awaiting requested review from dreamer-89 dreamer-89 is a code owner

gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

nknize Awaiting requested review from nknize nknize is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

tlfeng Awaiting requested review from tlfeng tlfeng is a code owner

VachaShah Awaiting requested review from VachaShah VachaShah is a code owner