Group adjacent ranges of component refs in the BOM table #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The reason I have not done this yet is that I want to finish wishlist from #17 first. There definitely is utility in controlling individually which ref was placed and having visual feedback for that. Once that is implemented grouping would have to take into account the state of the ref. Either way please hold off on this functionality until #17 and #52 are closed. |
|
Wait... are the images for Before and After labelled backwards? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20.
The component lookup box behaves just as before.
If you enter a ref that isn't from the end of a range into the filter box, it will still match the row, but with no highlight. I can improve this behaviour if you wish (highlight the range? expand out the relevant range and highlight the relevant part?)
From the motherboard demo:
After:
Before: