bug: Handle NoClassDefFoundError when loading YAML recipes with missing recipe dependencies

[bryceatmoderne]

What's changed?

Added logic to catch NoClassDefFoundError errors when loading YAML recipes with missing recipe dependencies

What's your motivation?

NoClassDefFoundError errors were previously not handled compromising troubleshooting.

Anything in particular you'd like reviewers to focus on?

Potential for regressed behaviour.

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

No

Any additional context

No

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

Thanks for taking this on! I take it you've tested this particular scenario then as well?

[timtebeek]

Had another look; when I modify the test case here to use an invalid class, it seems we're not entering the new catch block where I had expected that:

rewrite/rewrite-core/src/test/java/org/openrewrite/config/YamlResourceLoaderTest.java

Line 303 in 03c4584

- org.openrewrite.text.AppendToTextFile:

Also note that the new catch block is only added for Yaml resources that contain more than one document (or at least a --- separator), whereas it might be quite common to find resources without such a block and handle missing classes there as well.

Perhaps we should still add a test if possible to ensure we're catching in the right place and not missing certain cases.

[bryceatmoderne]

Perhaps we should still add a test if possible to ensure we're catching in the right place and not missing certain cases.

I've added exception handling for the String recipeData case. I've also added unit testing as suggested. The tests validate the behaviour when a NoClassDefFoundError is thrown when attempting to instantiate a recipe, however it does so in a contrived manner that is not analogous to how the Moderne customer encountered it.