Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation added on method parameter lacks whitespace separation with next annotation #3851

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeonyeonbin
Copy link

What's changed?

it is only provide testing.

What's your motivation?

i think autoFormat does between Annotation space but it doesnt` work

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

@timtebeek

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files


class Example {

public void method(@DeprecatedMethodParameter @Deprecated String method) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case i want to like this

but result is

public void method(@DeprecatedMethodParameter@Deprecated String method) {

have you ever provide solutions?

@jeonyeonbin jeonyeonbin marked this pull request as draft December 27, 2023 13:49
@seonWKim
Copy link
Contributor

seonWKim commented Jan 12, 2024

Hi, @koppor, shouldn't the consecutive annotations be separated? Does rewrite already provides above feature 🤔 ?

@timtebeek timtebeek self-requested a review January 15, 2024 14:01
@timtebeek timtebeek changed the title test: annotation add in method param Annotation added on method parameter lacks whitespace separation with next annotation Jan 16, 2024
@koppor
Copy link

koppor commented Jan 22, 2024

@seonwoo960000 I am "only" a user of OpenRewrite and don't know about all features. Since you are in the code, maybe, you can check the code?

@timtebeek timtebeek removed their request for review March 15, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants