Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: MRR data testing examples #49

Merged
merged 3 commits into from Mar 19, 2024
Merged

Conversation

rcjackson
Copy link
Contributor

I am adding test MRR2 data for the xradar MRR2 reader.

@kmuehlbauer
Copy link
Collaborator

@rcjackson Would it work to add the data gzipped? We can easily use fixtures to extract it in the test suite.

@@ -46,12 +49,6 @@ T_PAZD63_C_LFPW_20230420065331.h5 7a04d1e642839fbcc12736f39e8d845cd44f56387e7829
T_PAZD63_C_LFPW_20230420065831.h5 40cbb771bbe718c3fbdae91ab209e1f00759290ce01cee866e8e1c0e788aff91
T_PAZE63_C_LFPW_20230420065446.h5 bf65fefe5d46530cd5d210485dd8725dc23fe66945c0871041cf7ecbbbe19b86
T_PAZE63_C_LFPW_20230420065946.h5 c6db05d31a6e0209c1056f61f8839c2bf3eacf4869263d8393643cb05dc15cad
cfrad.20080604_002217_000_SPOL_v36_SUR.nc 67821b6c2bb0f27b5de49dee636f36e6e5bbad95f1ee168cb2d1af48e98992fe
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line, and those below, look like they should not be removed.

@rcjackson
Copy link
Contributor Author

I've fixed the registry to include all of the files and gzipped the MRR2 data.

Copy link
Collaborator

@kmuehlbauer kmuehlbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rcjackson, LGTM. I'm not sure if we should make a restructure for the README.md. But otherwise this is good to go.

@kmuehlbauer
Copy link
Collaborator

I'm not sure if we should make a restructure for the README.md.

@mgrover1 The list in the readme becomes longer and longer. It's not easy to see what kind of data is provided. Maybe we should make subsections for the different radar file formats? What do others think?

I think this should be done in a separate PR.

@mgrover1
Copy link
Contributor

I think we should add some dynamic documentation here, which could be tracked in a separate issue

@kmuehlbauer kmuehlbauer merged commit 9ab65f7 into openradar:main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants