(feat) O3-3112: Re-instate the Form collapse #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamaidrsk
changed the title
pirupius
requested changes
Apr 26, 2024
| import { SessionMode } from '../types'; | ||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| export function useFormCollapse(sessionMode: SessionMode) { |
There was a problem hiding this comment.
This looks over engineered. I would opt for passing this state to the FormEngine component within the esm-form-engine-app and use it to toggle the sections
| @@ -18,6 +18,7 @@ function Sidebar({ | |||
| setValues, | |||
| allowUnspecifiedAll, | |||
| defaultPage, | |||
| hideFormCollapseToggle, | |||
There was a problem hiding this comment.
Is there a particular reason u added this to the sidebar? there no sections in the sidebar (side navigation)
There was a problem hiding this comment.
I added this to be called when the the form is cancelled, so as to remove the toggle from workspace header.
usamaidrsk
force-pushed
the
ft-form-collapse
branch
from
a55c915
to
e9f979a
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
The PR re-instates the form collapse functionality, and this depends on this (feat) O3-3112: Add form collapse toggle to the
esm-form-engine-appScreenshots
form-collapse.mp4
Related Issue
O3-3112
Other