(fix) - O3-03130 - fix 'Add Provider Queue Room' dialog popping up wh…

[chibongho]

…en it should not

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• [] My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

The "Add Provider Queue Room" modal pops up unexpectedly sometimes when navigating to the service queues app. The current implementation has the dialog popping up when certain conditions are met. The PR changes it to appear by pressing a button in the "Clinics Metrics" section instead.

A previous commit added some UI changes to show the buttons at the "Clinic Metrics" section has a ComboButton on mobile. However, it also made a (probably) unintentional change to hide the "Queue Screen" button behind the Emr: View Legacy Interface privilege. This PR reverts it to the old behavior.

I just made it always use the ComboButton, regardless of whether the browser is on mobile or desktop. Let me know if that's not ok.

Screenshots

When logged in as admin:

When logged in as nurse:

Related Issue

Other

[github-actions]

Size Change: -163 kB (-5%) ✅

Total Size: 3.22 MB

Filename	Size	Change
packages/esm-service-queues-app/dist/745.js	0 B	-159 kB (removed)	🏆

ℹ️ View Unchanged

Filename	Size	Change
packages/esm-active-visits-app/dist/130.js	169 kB	0 B
packages/esm-active-visits-app/dist/255.js	2.21 kB	0 B
packages/esm-active-visits-app/dist/271.js	762 B	0 B
packages/esm-active-visits-app/dist/277.js	13.4 kB	0 B
packages/esm-active-visits-app/dist/316.js	42.9 kB	0 B
packages/esm-active-visits-app/dist/319.js	683 B	0 B
packages/esm-active-visits-app/dist/382.js	1.15 kB	0 B
packages/esm-active-visits-app/dist/448.js	47.1 kB	0 B
packages/esm-active-visits-app/dist/460.js	784 B	0 B
packages/esm-active-visits-app/dist/574.js	588 B	0 B
packages/esm-active-visits-app/dist/588.js	6.66 kB	0 B
packages/esm-active-visits-app/dist/635.js	1.15 kB	0 B
packages/esm-active-visits-app/dist/644.js	762 B	0 B
packages/esm-active-visits-app/dist/729.js	3.1 kB	0 B
packages/esm-active-visits-app/dist/757.js	694 B	0 B
packages/esm-active-visits-app/dist/784.js	2.63 kB	0 B
packages/esm-active-visits-app/dist/788.js	586 B	0 B
packages/esm-active-visits-app/dist/807.js	918 B	0 B
packages/esm-active-visits-app/dist/833.js	732 B	0 B
packages/esm-active-visits-app/dist/879.js	2.94 kB	0 B
packages/esm-active-visits-app/dist/main.js	65 kB	0 B
packages/esm-active-visits-app/dist/openmrs-esm-active-visits-app.js	3.33 kB	0 B
packages/esm-appointments-app/dist/123.js	257 kB	0 B
packages/esm-appointments-app/dist/130.js	169 kB	0 B
packages/esm-appointments-app/dist/152.js	257 B	0 B
packages/esm-appointments-app/dist/255.js	2.22 kB	0 B
packages/esm-appointments-app/dist/271.js	1.97 kB	0 B
packages/esm-appointments-app/dist/286.js	9.34 kB	0 B
packages/esm-appointments-app/dist/303.js	258 B	0 B
packages/esm-appointments-app/dist/319.js	1.89 kB	0 B
packages/esm-appointments-app/dist/390.js	26 kB	0 B
packages/esm-appointments-app/dist/4.js	1.77 kB	0 B
packages/esm-appointments-app/dist/460.js	2.07 kB	0 B
packages/esm-appointments-app/dist/574.js	1.85 kB	0 B
packages/esm-appointments-app/dist/588.js	6.65 kB	0 B
packages/esm-appointments-app/dist/591.js	16.9 kB	0 B
packages/esm-appointments-app/dist/644.js	1.97 kB	0 B
packages/esm-appointments-app/dist/719.js	46.1 kB	0 B
packages/esm-appointments-app/dist/729.js	3.1 kB	0 B
packages/esm-appointments-app/dist/757.js	1.74 kB	0 B
packages/esm-appointments-app/dist/784.js	2.63 kB	0 B
packages/esm-appointments-app/dist/788.js	1.68 kB	0 B
packages/esm-appointments-app/dist/807.js	2.31 kB	0 B
packages/esm-appointments-app/dist/833.js	1.97 kB	0 B
packages/esm-appointments-app/dist/main.js	315 kB	0 B
packages/esm-appointments-app/dist/openmrs-esm-appointments-app.js	3.43 kB	0 B
packages/esm-patient-list-management-app/dist/130.js	169 kB	0 B
packages/esm-patient-list-management-app/dist/255.js	2.21 kB	0 B
packages/esm-patient-list-management-app/dist/271.js	1.55 kB	0 B
packages/esm-patient-list-management-app/dist/295.js	99.3 kB	0 B
packages/esm-patient-list-management-app/dist/319.js	1.52 kB	0 B
packages/esm-patient-list-management-app/dist/382.js	1.15 kB	0 B
packages/esm-patient-list-management-app/dist/460.js	1.7 kB	0 B
packages/esm-patient-list-management-app/dist/574.js	1.34 kB	0 B
packages/esm-patient-list-management-app/dist/588.js	6.66 kB	0 B
packages/esm-patient-list-management-app/dist/591.js	16.9 kB	0 B
packages/esm-patient-list-management-app/dist/635.js	1.15 kB	0 B
packages/esm-patient-list-management-app/dist/644.js	1.55 kB	0 B
packages/esm-patient-list-management-app/dist/716.js	4.66 kB	0 B
packages/esm-patient-list-management-app/dist/729.js	3.1 kB	0 B
packages/esm-patient-list-management-app/dist/757.js	1.5 kB	0 B
packages/esm-patient-list-management-app/dist/784.js	2.64 kB	0 B
packages/esm-patient-list-management-app/dist/788.js	1.34 kB	0 B
packages/esm-patient-list-management-app/dist/807.js	1.84 kB	0 B
packages/esm-patient-list-management-app/dist/833.js	1.58 kB	0 B
packages/esm-patient-list-management-app/dist/995.js	21.9 kB	0 B
packages/esm-patient-list-management-app/dist/main.js	125 kB	0 B
packages/esm-patient-list-management-app/dist/openmrs-esm-patient-list-management-app.js	3.3 kB	0 B
packages/esm-patient-registration-app/dist/130.js	169 kB	0 B
packages/esm-patient-registration-app/dist/152.js	262 B	0 B
packages/esm-patient-registration-app/dist/255.js	2.21 kB	0 B
packages/esm-patient-registration-app/dist/271.js	2.01 kB	0 B
packages/esm-patient-registration-app/dist/303.js	260 B	0 B
packages/esm-patient-registration-app/dist/319.js	1.99 kB	0 B
packages/esm-patient-registration-app/dist/460.js	2.12 kB	0 B
packages/esm-patient-registration-app/dist/481.js	6.75 kB	0 B
packages/esm-patient-registration-app/dist/537.js	2.34 kB	0 B
packages/esm-patient-registration-app/dist/574.js	1.7 kB	0 B
packages/esm-patient-registration-app/dist/591.js	16.9 kB	0 B
packages/esm-patient-registration-app/dist/644.js	2.01 kB	0 B
packages/esm-patient-registration-app/dist/676.js	6.59 kB	0 B
packages/esm-patient-registration-app/dist/686.js	92 kB	0 B
packages/esm-patient-registration-app/dist/729.js	3.1 kB	0 B
packages/esm-patient-registration-app/dist/735.js	464 B	0 B
packages/esm-patient-registration-app/dist/757.js	2.07 kB	0 B
packages/esm-patient-registration-app/dist/783.js	36.3 kB	0 B
packages/esm-patient-registration-app/dist/784.js	2.64 kB	0 B
packages/esm-patient-registration-app/dist/788.js	1.7 kB	0 B
packages/esm-patient-registration-app/dist/807.js	2.43 kB	0 B
packages/esm-patient-registration-app/dist/833.js	1.97 kB	0 B
packages/esm-patient-registration-app/dist/879.js	2.94 kB	0 B
packages/esm-patient-registration-app/dist/main.js	130 kB	0 B
packages/esm-patient-registration-app/dist/openmrs-esm-patient-registration-app.js	3.34 kB	0 B
packages/esm-patient-search-app/dist/130.js	169 kB	0 B
packages/esm-patient-search-app/dist/255.js	2.21 kB	0 B
packages/esm-patient-search-app/dist/271.js	899 B	0 B
packages/esm-patient-search-app/dist/319.js	857 B	0 B
packages/esm-patient-search-app/dist/382.js	1.15 kB	0 B
packages/esm-patient-search-app/dist/460.js	924 B	0 B
packages/esm-patient-search-app/dist/574.js	732 B	0 B
packages/esm-patient-search-app/dist/584.js	21.7 kB	0 B
packages/esm-patient-search-app/dist/588.js	6.66 kB	0 B
packages/esm-patient-search-app/dist/591.js	16.9 kB	0 B
packages/esm-patient-search-app/dist/635.js	1.15 kB	0 B
packages/esm-patient-search-app/dist/644.js	899 B	0 B
packages/esm-patient-search-app/dist/729.js	3.1 kB	0 B
packages/esm-patient-search-app/dist/757.js	864 B	0 B
packages/esm-patient-search-app/dist/778.js	23.2 kB	0 B
packages/esm-patient-search-app/dist/784.js	2.63 kB	0 B
packages/esm-patient-search-app/dist/788.js	726 B	0 B
packages/esm-patient-search-app/dist/807.js	1.03 kB	0 B
packages/esm-patient-search-app/dist/833.js	867 B	0 B
packages/esm-patient-search-app/dist/main.js	48 kB	0 B
packages/esm-patient-search-app/dist/openmrs-esm-patient-search-app.js	3.3 kB	0 B
packages/esm-service-queues-app/dist/130.js	169 kB	0 B
packages/esm-service-queues-app/dist/152.js	262 B	0 B
packages/esm-service-queues-app/dist/233.js	1.73 kB	0 B
packages/esm-service-queues-app/dist/255.js	2.22 kB	0 B
packages/esm-service-queues-app/dist/263.js	3.46 kB	0 B
packages/esm-service-queues-app/dist/271.js	4.12 kB	0 B
packages/esm-service-queues-app/dist/303.js	261 B	0 B
packages/esm-service-queues-app/dist/319.js	3.54 kB	0 B
packages/esm-service-queues-app/dist/328.js	2.99 kB	0 B
packages/esm-service-queues-app/dist/389.js	1.89 kB	0 B
packages/esm-service-queues-app/dist/425.js	2.09 kB	0 B
packages/esm-service-queues-app/dist/460.js	4.4 kB	0 B
packages/esm-service-queues-app/dist/50.js	3.04 kB	0 B
packages/esm-service-queues-app/dist/574.js	3.52 kB	-2 B (0%)
packages/esm-service-queues-app/dist/588.js	6.66 kB	0 B
packages/esm-service-queues-app/dist/591.js	16.9 kB	0 B
packages/esm-service-queues-app/dist/616.js	0 B	-2.72 kB (removed)	🏆
packages/esm-service-queues-app/dist/644.js	4.12 kB	0 B
packages/esm-service-queues-app/dist/694.js	2.65 kB	0 B
packages/esm-service-queues-app/dist/696.js	570 B	0 B
packages/esm-service-queues-app/dist/729.js	3.1 kB	0 B
packages/esm-service-queues-app/dist/738.js	554 B	0 B
packages/esm-service-queues-app/dist/757.js	3.54 kB	0 B
packages/esm-service-queues-app/dist/784.js	2.63 kB	0 B
packages/esm-service-queues-app/dist/788.js	3.54 kB	0 B
packages/esm-service-queues-app/dist/806.js	1.6 kB	0 B
packages/esm-service-queues-app/dist/807.js	4.83 kB	0 B
packages/esm-service-queues-app/dist/833.js	4.09 kB	0 B
packages/esm-service-queues-app/dist/871.js	50.3 kB	-525 B (-1%)
packages/esm-service-queues-app/dist/940.js	21.4 kB	0 B
packages/esm-service-queues-app/dist/966.js	159 kB	0 B
packages/esm-service-queues-app/dist/981.js	2.94 kB	0 B
packages/esm-service-queues-app/dist/main.js	212 kB	-624 B (0%)
packages/esm-service-queues-app/dist/openmrs-esm-service-queues-app.js	3.31 kB	+1 B (0%)

_{compressed-size-action}

[mseaton]

I defer entirely to the Palladium team on this.

[ojwanganto]

Thanks, @chibongho. We are fine with the changes. One question though, will we maintain the queue screen button as a separate button from the other actions list, or will we add viewing queue screen as one of the actions?

[chibongho]

Thanks, @chibongho. We are fine with the changes. One question though, will we maintain the queue screen button as a separate button from the other actions list, or will we add viewing queue screen as one of the actions?

@ojwanganto The ComboButton is a strange carbon element. It requires a "Primary action" that is always displayed, plus a list of other actions that are within a menu. I have placed the "Queue screen" button as the primary action, and the other actions in the menu.