Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-3127: Make the All Day feature in the appointments form disabled by default #1113

Merged
merged 1 commit into from May 14, 2024

Conversation

mccarthyaaron
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The All Day appointments feature is currently enabled by default in the ref app. This PR aims at making it disabled by default such that any implementers who want to use it will have to enable it by themselves through configuration.

To achieve this the PR changes the default value of the allowAllDayAppointment property in the config-schema from true to false

##Screenshots
Here is the before:

before.mp4

Here is the after

after.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-3127

Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ojwanganto does this change work for you?

if so, LGTM...

Copy link

@ojwanganto ojwanganto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with us. Thanks @mccarthyaaron

@mogoodrich
Copy link
Member

Thanks @ojwanganto ... I see no blockers for merging @mccarthyaaron !

@mccarthyaaron
Copy link
Contributor Author

@mogoodrich Does this PR still have any unresolved issues? If not, I was kindly requesting that it gets merged

@mogoodrich mogoodrich merged commit 87510b8 into openmrs:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants