O3-2396: Appointments: Refine logic for whether a patient is checked … #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -45.8 kB (-1%) Total Size: 3.23 MB
ℹ️ View Unchanged
|
|
see my comments here: https://openmrs.atlassian.net/browse/O3-2963 ... we can have broader discussions about making this change there. |
mogoodrich
requested review from
chibongho,
mseaton,
donaldkibet and
ojwanganto
mseaton
reviewed
Apr 24, 2024
| const hasActiveVisitToday = visits?.some((visit) => visit?.patient?.uuid === patientUuid && visit?.startDatetime); | ||
| const hasCheckedOutToday = visits?.some( | ||
| (visit) => visit?.patient?.uuid === patientUuid && visit?.startDatetime && visit?.stopDatetime, | ||
| ); |
There was a problem hiding this comment.
As we discovered when looking at this today, this change can't be made in isolation of the changes to the checkout functionality, which currently will end the active visit. Always ending the active visit makes sense when your checkout logic is based on the presence of an active visit. But once you change the check-out logic to be independent of the visit status, you'll need to check that the visit is not already ended and/or prompt if the user wants to also close the visit, when you issue the modal dialog and perform the operation.
There was a problem hiding this comment.
Yeah, I likely want to tweak this.
|
Ack, I have to modify my commit message to include "BREAKING".... |
|
Converting this to a draft, we don't want to merge this in until we properly are able to switch appointment actions via the default paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in or not
Requirements
Summary
Screenshots
Related Issue
Other