(test) O3-2428: E2E test for appointment scheduling #1062

Vijaykv5 · 2024-03-25T15:56:57Z

Requirements

This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
My work includes tests or is validated by existing tests.

Summary

This PR covers E2E test to test the appointment workflow.

The test involves adding an appointment for a patient, edit the added appointment, and cancel it.

Screenshots

appointments-test.mov

Related Issue

O3-2428
O3-2891

denniskigen · 2024-03-25T19:32:24Z

You need to switch from the Upcoming tab to the Today tab before cancelling the appointment. As you've edited the date to today, your scheduled appointment moved to the Today tab, @Vijaykv5.

jayasanka-sack

Hey @Vijaykv5 ,

Could you please address this as well? openmrs/openmrs-esm-patient-chart#1664 (comment)

kdaud · 2024-03-27T04:47:21Z

@Vijaykv5 could you address the pending reviews and we get this PR merged?

Vijaykv5 · 2024-03-27T05:27:07Z

@Vijaykv5 could you address the pending reviews and we get this PR merged?

Yes @kdaud I'll do it today

Vijaykv5 · 2024-03-27T13:10:24Z

@jayasanka-sack had a discussion with @denniskigen on this PR during coffee break and why it's failing.
He told that the possible reasons may be with the timezone as we checked it locally and it's was working fine without any errors.

Vijaykv5 · 2024-03-27T13:12:15Z

Hey @Vijaykv5 ,

Could you please address this as well? openmrs/openmrs-esm-patient-chart#1664 (comment)

So do we need to split up the this into three tests? Add, Edit and Cancel appointments?

kdaud · 2024-03-27T13:30:20Z

why it's failing. the possible reasons may be with the timezone as we checked it locally and it's was working fine without any errors.

Let me skim through the code....

kdaud · 2024-03-27T13:56:41Z

e2e/specs/appointments.spec.ts

+  await test.step('And I change the date to Today', async () => {
+    const today = new Date();
+    today.setDate(today.getDate());
+    await page.fill('input[placeholder="dd/mm/yyyy"]', today.toLocaleDateString('en-GB'));


Just as @denniskigen mentioned, this action changes the appointment date from what was set before (Tomorrow) to Today and thus requires in the preceding actions to switch the test to click on Today's tab before clicking the options menu...

e2e/specs/appointments.spec.ts

kdaud · 2024-03-29T07:11:40Z

@Vijaykv5 please fix the failing build and also address the pending review at #1062 (review)

Vijaykv5 · 2024-03-29T09:57:11Z

@kdaud could you help me with solving this error in E2E tests?

kdaud · 2024-03-29T10:02:52Z

@kdaud could you help me with solving this error in E2E tests?

Are you able to reproduce the issue?

Vijaykv5 · 2024-03-29T10:23:57Z

@kdaud could you help me with solving this error in E2E tests?

Are you able to reproduce the issue?

Actually nope! it's just the error in github cli

But now when saperating each actions, how can we get same patient uuid, so that the add,edit and delete can happen with a single patient.

kdaud · 2024-03-29T10:52:39Z

Actually nope! it's just the error in github cli

Double check with the element locator being cited in the logs.

@Vijaykv5 regarding this review did you reach out to Jayasanka as mentioned on one of the coffee break?

Vijaykv5 · 2024-03-29T11:07:46Z

Actually nope! it's just the error in github cli

Double check with the element locator being cited in the logs.

@Vijaykv5 regarding this review did you reach out to Jayasanka as mentioned on one of the coffee break?

cool I'll just checkout with him

Vijaykv5 · 2024-03-31T17:30:51Z

While creating appointment locally as well as in dev3, there is no data under select option
This is the reason for this PR failure.

Screen.Recording.2024-03-31.at.10.51.37.PM.mov

cc: @kdaud @jayasanka-sack

kdaud · 2024-04-15T11:10:52Z

@Vijaykv5 are you able to reproduce the issue on a local instance?

Vijaykv5 · 2024-04-15T18:05:49Z

@Vijaykv5 are you able to reproduce the issue on a local instance?

Yes @kdaud the same I mentioned above

kdaud · 2024-04-16T07:20:18Z

I'll take a look when the dev3 is back.

kdaud · 2024-04-16T07:22:32Z

@Vijaykv5 in reference to this comment, refer to the desired approach: https://openmrs.atlassian.net/browse/O3-3064?focusedCommentId=140494

denniskigen · 2024-05-08T10:51:27Z

Any updates on this, @Vijaykv5?

Vijaykv5 · 2024-05-08T12:52:16Z

@denniskigen So I've made all add, edit and delete into single test for now.
In future, we'll try to separate them for each actions.

May you can review this.

Thanks!

e2e/specs/appointments.spec.ts

denniskigen

Thanks for working on this, @Vijaykv5! I've commented out one test case related to locations failing to load in the test environment. It'd be great if this could be sorted out when working on separating out the test cases into independent steps.

Vijaykv5 mentioned this pull request Mar 25, 2024

(test) O3-2428: E2E test for appointment scheduling openmrs/openmrs-esm-patient-chart#1664

Closed

3 tasks

jayasanka-sack reviewed Mar 26, 2024

View reviewed changes

Vijaykv5 force-pushed the test/O3-2428 branch from 081a3e0 to dcb98e9 Compare March 27, 2024 12:59

kdaud reviewed Mar 27, 2024

View reviewed changes

Vijaykv5 requested a review from kdaud March 29, 2024 06:49

Vijaykv5 added 3 commits May 8, 2024 19:37

Updated E2E tests for appointments

c85e691

fix : Updated minor changes

684effa

fix : separated add,edit,delete appointments

b509bbb

denniskigen force-pushed the test/O3-2428 branch from c43df6f to 8f1bdd0 Compare May 8, 2024 16:38

Vijaykv5 commented May 8, 2024

View reviewed changes

e2e/specs/appointments.spec.ts Outdated Show resolved Hide resolved

feat : Update tests

1c5cbd1

denniskigen force-pushed the test/O3-2428 branch from 8f1bdd0 to 1c5cbd1 Compare May 8, 2024 19:06

denniskigen added 2 commits May 8, 2024 22:35

Comment out logic for selecting a location from the locations dropdown

16f590a

Comment out test case for cancelling a scheduled appointment

d463497

denniskigen force-pushed the test/O3-2428 branch 2 times, most recently from fc0c9e0 to 5f04f04 Compare May 8, 2024 20:11

Restore logic for Cancel case

a1b4310

denniskigen force-pushed the test/O3-2428 branch from 5f04f04 to a1b4310 Compare May 8, 2024 20:21

denniskigen approved these changes May 8, 2024

View reviewed changes

denniskigen merged commit 65cb1bd into openmrs:main May 8, 2024
6 checks passed

Vijaykv5 deleted the test/O3-2428 branch May 8, 2024 23:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(test) O3-2428: E2E test for appointment scheduling #1062

(test) O3-2428: E2E test for appointment scheduling #1062

Vijaykv5 commented Mar 25, 2024 •

edited by jira bot

denniskigen commented Mar 25, 2024

jayasanka-sack left a comment

kdaud commented Mar 27, 2024

Vijaykv5 commented Mar 27, 2024

Vijaykv5 commented Mar 27, 2024 •

edited

Vijaykv5 commented Mar 27, 2024 •

edited

kdaud commented Mar 27, 2024 •

edited

kdaud Mar 27, 2024 •

edited

kdaud commented Mar 29, 2024 •

edited

Vijaykv5 commented Mar 29, 2024 •

edited

kdaud commented Mar 29, 2024

Vijaykv5 commented Mar 29, 2024

kdaud commented Mar 29, 2024 •

edited

Vijaykv5 commented Mar 29, 2024

Vijaykv5 commented Mar 31, 2024

kdaud commented Apr 15, 2024

Vijaykv5 commented Apr 15, 2024

kdaud commented Apr 16, 2024

kdaud commented Apr 16, 2024

denniskigen commented May 8, 2024

Vijaykv5 commented May 8, 2024

denniskigen left a comment

(test) O3-2428: E2E test for appointment scheduling #1062

(test) O3-2428: E2E test for appointment scheduling #1062

Conversation

Vijaykv5 commented Mar 25, 2024 • edited by jira bot

Requirements

Summary

Screenshots

Related Issue

denniskigen commented Mar 25, 2024

jayasanka-sack left a comment

Choose a reason for hiding this comment

kdaud commented Mar 27, 2024

Vijaykv5 commented Mar 27, 2024

Vijaykv5 commented Mar 27, 2024 • edited

Vijaykv5 commented Mar 27, 2024 • edited

kdaud commented Mar 27, 2024 • edited

kdaud Mar 27, 2024 • edited

Choose a reason for hiding this comment

kdaud commented Mar 29, 2024 • edited

Vijaykv5 commented Mar 29, 2024 • edited

kdaud commented Mar 29, 2024

Vijaykv5 commented Mar 29, 2024

kdaud commented Mar 29, 2024 • edited

Vijaykv5 commented Mar 29, 2024

Vijaykv5 commented Mar 31, 2024

kdaud commented Apr 15, 2024

Vijaykv5 commented Apr 15, 2024

kdaud commented Apr 16, 2024

kdaud commented Apr 16, 2024

denniskigen commented May 8, 2024

Vijaykv5 commented May 8, 2024

denniskigen left a comment

Choose a reason for hiding this comment

Vijaykv5 commented Mar 25, 2024 •

edited by jira bot

Vijaykv5 commented Mar 27, 2024 •

edited

Vijaykv5 commented Mar 27, 2024 •

edited

kdaud commented Mar 27, 2024 •

edited

kdaud Mar 27, 2024 •

edited

kdaud commented Mar 29, 2024 •

edited

Vijaykv5 commented Mar 29, 2024 •

edited

kdaud commented Mar 29, 2024 •

edited