(chore) O3-2120: Move OpenMRS ID patient search identifier to defaultIdentifierTypes
#1061
Conversation
usamaidrsk
changed the title
OpenMRS ID identifier to defaultIdentifierTypes in the config-schema.tsOpenMRS ID patient search identifier to defaultIdentifierTypes
There was a problem hiding this comment.
Thanks @usamaidrsk ! Defer to @denniskigen and @ibacher who may have a better sense of how this is all used, but generally looks good to me.
| 'b4d66522-11fc-45c7-83e3-39a1af21ae0d', | ||
| 'f85081e2-b4be-4e48-b3a4-7994b69bb101', | ||
| '05a29f94-c0ed-11e2-94be-8c13b969e334', | ||
| ], |
There was a problem hiding this comment.
IMO we shouldn't be hardcoding any identifier uuids here but this should come from the ref app configuration, but I know there's not agreement on that (and that this is existing code, not a change introduced as part of this code)
There was a problem hiding this comment.
Thanks @mogoodrich for the feedback.
The only uuid introduced is one for the OpenMRS ID, that's the last in the list.
There was a problem hiding this comment.
What are the other identifiers then?
There was a problem hiding this comment.
So, these first two identifiers are Palladium-specific. Those are the Patient Clinic Number and the NUPI number. They should be provided via distro configuration instead of being hardcoded in the Patient Search config schema. @donaldkibet, can @usamaidrsk proceed to remove them from here?
There was a problem hiding this comment.
From the config file there is this comment, for the first two.
These values correspond to the Patient Clinic Number and National Unique Patient Identifier (NUPI) identifier types respectively
There was a problem hiding this comment.
Thanks @denniskigen ! In fairness to @usamaidrsk looks like those two identifiers constants existed prior to this PR, but if they are implementation-specific, they definitely should be removed as defaults. @donaldkibet
| <FallbackIdentifier patient={patients[index]} identifierName={config.defaultIdentifier} /> | ||
| )} | ||
| </> | ||
| <DefaultIdentifiers identifiers={patientIdentifiers} /> |
There was a problem hiding this comment.
What happens if the configuration still specifies no patient identifiers? It seems like we still need some fallback here.
… config-schema
Requirements
Summary
This PR moves
OpenMRS IDidentifier todefaultIdentifierTypesin theconfig-schema.tsScreenshots
Related Issue
O3-2120
Other