Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)Back to search results button #1051

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Mar 19, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I fixed the Back button to take the user back to search results. To achieve this, I modified the onClick handler of the Back button to call the toggleSearchType function with the SEARCH_RESULTS mode.

Screenshots

screencast.2024-03-19.6.PM-23-06.mp4

Related Issue

Other

@jwnasambu
Copy link
Contributor Author

jwnasambu commented Mar 19, 2024

@mseaton I was just playing around with code after your discussion on this ticket https://openmrs.atlassian.net/browse/O3-2467 and after reaching out @Samsino during the coffee break and other members.

@mseaton mseaton self-requested a review March 21, 2024 15:13
Copy link
Member

@mseaton mseaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwnasambu . A few things :

  1. The behavior is supposed to be that if you are in the full visit form, but you got here from the list of appointments, then the current feature remains, but if you go into the full visit form without first going to the list of appointments, then it needs to go back to search results.
  2. In your screencast, it doesn't actually look like the search results that you go back to is working. Does the search you go back to actually render as expected?

@jwnasambu
Copy link
Contributor Author

@mseaton Thanks so so much for your guidance its what I needed most.Let me kick start from there. Once again, am so so grateful for your help.

@sam-sny
Copy link

sam-sny commented Mar 22, 2024

Nice one @jwnasambu, Thanks for hoping on this, Changes need to me made on the extension to sort this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants