Fix: Back to search results button functionality #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Back to search results button issue
mseaton
requested changes
Mar 17, 2024
| renderIcon={(props) => <ArrowLeft size={24} {...props} />} | ||
| iconDescription={t('backToSearchResult', 'Back to search result')} | ||
| size="sm" | ||
| onClick={closePanel}> |
There was a problem hiding this comment.
This would seem to indicate that clicking on this button will close the entire overlay / search panel entirely, not actually return to the search result. If the goal is to return to the search result, can you show that this is what this does?
| onClick={() => toggleSearchType(SearchTypes.SCHEDULED_VISITS, patientUuid)}> | ||
| <span>{t('backToScheduledVisits', 'Back to scheduled visits')}</span> | ||
| onClick={closePanel}> | ||
| <span>{t('backToSearchResult', 'Back to search result')}</span> |
There was a problem hiding this comment.
Same here. Does the "closePanel" function actually return you to the search result? Or does it close the panel entirely? If it closes the panel, this would seem incorrect.
Vijaykv5
reviewed
Mar 22, 2024
| @@ -21,14 +21,15 @@ | |||
| "@hookform/resolvers": "^3.3.1", | |||
| "classnames": "^2.3.2", | |||
| "react-hook-form": "^7.46.2", | |||
| "react-joyride": "^2.8.0", | |||
There was a problem hiding this comment.
Why are you adding a third party library for fixing this issue? @sam-sny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Updated the 'Back to search results' button text and functionality. Replaced the original text with 'Back to search result' and implemented a function to close the panel when the button is clicked. This enhancement ensures a more intuitive user experience by providing clear navigation back to search results.
Screenshots
Before:
After:
patient-scheduled-visit:
visit-form:
Related Issue
https://openmrs.atlassian.net/browse/O3-2467
Other