Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar visit types are long - totals not showing #1024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gabriel090
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Images of Small screen or tablet screen before modification.
smallScreenBeforeModified

Image of small screen after modification
smallScreenAfter

Image of the large screen before modification
fullScreenBefore

Image of the full screen after modification
fullScreenAfter

Related Issue

Other

{isSameMonth(dateTime, dayjs(selectedDate)) && <b className={styles.calendarDate}>{dateTime.format('D')}</b>}
</div>
);
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single check for currentData while calling isSameMonth() should be fine, no need for if-else clause.
Rest looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants