in the OTZ Discontinuation form, does not save the correct data when … #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…saved in the database upon successful submit. For instance Opt out of OTZ in the form will display discontinue
donaldkibet
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Thanks @gabriel090. Ensure you follow the community guidelines for contributing here by having a good PR description and summary. Also include a ticket for this work.
Comment on lines
+9
to
+10
| export const otzUuid = '159836AAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'; | ||
| export const otzOutPut = 'Opt out of OTZ'; |
There was a problem hiding this comment.
We don't need this hard coded values. These should be provided by the config file
| @@ -12,15 +13,22 @@ interface EncounterObservationsProps { | |||
| const EncounterObservations: React.FC<EncounterObservationsProps> = ({ observations }) => { | |||
| const { t } = useTranslation(); | |||
| const { obsConceptUuidsToHide = [] } = useConfig(); | |||
| const { obsConceptDisplayOverrides = { otzUuid: otzOutPut } } = useConfig(); | |||
There was a problem hiding this comment.
Suggested change
| const { obsConceptDisplayOverrides = { otzUuid: otzOutPut } } = useConfig(); | |
| const { obsConceptDisplayOverrides = useConfig(); |
donaldkibet
reviewed
Apr 18, 2024
Comment on lines
-63
to
-68
|
|
||
| return ( | ||
| <div className={styles.observation}> | ||
| <p>{t('noObservationsFound', 'No observations found')}</p> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Why are we removing this empty status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the OTZ Discontinuation form, does not save the correct data when saved in the database upon successful submission. For instance, Opt out of OTZ in the form will display discontinue
Requirements
Summary
Screenshots
This is the image of the error.
Related Issue
Other