New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Implement a two column layout for large desktops #1772
base: main
Are you sure you want to change the base?
Conversation
Thanks so much Jayasanka, great to see this taking shape! I've asked Paul Adams to have a look here for quick design-intent double-check.
|
Hi @jayasanka-sack. Thanks for sharing the video of the progress so far, it's good to see the two column view taking shape and utilising the space more effectively for those users with bigger monitors! I have a couple of immediate thoughts on the behaviour of the UI so far...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jayasanka-sack , please address the conflicts
I had a chat with @ibacher about this matter. The idea was to make the column width configurable (as it was previously). Unlike the previous, I added a new widget meta Regarding masonry layout, I highly agree that would be the best way to arrange tiles. The masonry layout for grids is only an experimental feature on browsers, so we should think of an alternative way. but it's doable. I will address it separately. I chatted with @ibacher about tweaking column widths. We've decided to bring back the option to adjust them, and I've also added a new widget meta On the masonry layout, I totally agree it's the best way to arrange tiles. Masonry layout on grids is still an experimental feature in browsers, so we might need to think of other ways, but I'm confident we can figure something out. I'll dive deeper into this one separately. Ian's comment:
|
bf41678
to
e203cad
Compare
Requirements
Summary
This pull request enhances the patient chart display to optimize space utilization on large desktop screens. The current implementation displays widgets in a single column, resulting in underutilized space. The proposed changes introduce a 2-column layout for widgets, ensuring better use of available screen real estate.
Key Changes:
🎾 Demo
Quick Demo and Overview of Layout Functionality - Watch Video
https://openmrs.atlassian.net/browse/O3-3024
Other