Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix): Added Error Handling cases in patient-list-details #1763

Closed
wants to merge 4 commits into from

Conversation

Madhu-mac
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR handles all the null value checks and adds Error handling functionalities

Other

Copy link
Contributor

@Twiineenock Twiineenock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madhu-mac could you attach some screanshots if possible

@@ -35,6 +35,10 @@ const PatientListDetailsTable: React.FC<PatientListDetailsTableProps> = ({ listM
const [searchTerm, setSearchTerm] = useState('');
const debouncedSearchTerm = useDebounce(searchTerm);

if (!listMembers) {
return null; // or return a loading indicator or placeholder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An isLoading condition below renders a loading skeleton. Error states are handled using the ErrorState component.

@denniskigen
Copy link
Member

Please file a ticket first addressing the specific issue you're solving, @Madhu-mac.

@denniskigen denniskigen closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants