Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix): chart review component optimized #1762

Closed
wants to merge 2 commits into from

Conversation

Madhu-mac
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR will add functionality in the code by adding usememo for better callback usage & also added error handling on top of it for better optimized performance and readability in the code

Screenshots

Related Issue

Other

@Madhu-mac
Copy link
Contributor Author

@jwnasambu @denniskigen
Can you verify this PR once

@jwnasambu
Copy link
Contributor

jwnasambu commented Mar 28, 2024

@Madhu-mac Kindly attach the ticket link of the issue you are working on to the Related Issue section for easy review.

@Madhu-mac
Copy link
Contributor Author

Madhu-mac commented Mar 28, 2024

@jwnasambu It doesn't have any tickets raised on this. I've added enhancement to the code for optimization and better results. I've also tested this locally

@brandones
Copy link
Contributor

Hi @Madhu-mac it's not obvious to me that this would improve performance. Whether useMemo improves performance depends on what it's being used for. Could you please provide some evidence that this improves performance?

@denniskigen
Copy link
Member

I agree with @brandones here. It would help to have at the very least some before and after profiling data from the React Dev tools to support the claim. Also, it'd be ideal to file a ticket first related to addressing performance concerns in the Patient Chart. Feel free to reopen this PR when you have these pre-requisites taken care of. Thanks!

@denniskigen denniskigen closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants