(refactor) 03-2973: Remove dead code from the results viewer implementation #1751
Conversation
There was a problem hiding this comment.
@mccarthyaaron any idea this PR may be failing e2e tests?
Does it pass the e2e tests when executed on your local, please?
| const handleInputChange = useCallback( | ||
| (e) => { | ||
| setSearchTerm(searchTerm); | ||
| (searchTerm) => { |
There was a problem hiding this comment.
What is the reason for this change?
Changing the event to a string will not work, until you make change in the said onClick function.
There was a problem hiding this comment.
@vasharma05 should I revert it to the original? Also help explain abit more as I haven't understood what you mean by the "the said onClick function". But this was my thought process: When the such term changes, the handleInputChange function is called with the search term passed as an argument. We then use that search term to get the filtered results. Previously 'e' was not being used anywhere in the handleInputChange function and I didn't understand why we are using an event as a parameter yet handleInputChange is being passed a string. Also though that maybe setting the search term( setSearchTerm(searchTerm) ) to the same value is kinda redudant. Thats how I thought about it. I am willing to be corrected
Summary
Remove dead code from the results viewer implementation
Related Issue
https://openmrs.atlassian.net/browse/O3-2973