(feat) O3-2117: Save orders and encounters in the same transaction #1727
Conversation
denniskigen
changed the title
There was a problem hiding this comment.
Thanks for working on this, @usamaidrsk. I've left a few suggestions
packages/esm-patient-orders-app/src/order-basket/order-basket.workspace.tsx
Outdated
Show resolved
Hide resolved
| @@ -116,21 +124,27 @@ const OrderBasket: React.FC<DefaultWorkspaceProps> = ({ | |||
| <InlineNotification | |||
| kind="error" | |||
| title={t('errorCreatingAnEncounter', 'Error when creating an encounter')} | |||
| subtitle={t('tryReopeningTheWorkspaceAgain', 'Please try launching the workspace again')} | |||
There was a problem hiding this comment.
I think it's best to show the original message here instead of the error message from the backend, which we're already logging to the console on line 67.
There was a problem hiding this comment.
I think that's right.
Just what I thought that given on creating the encounter we're adding orders too, then if the error was from the orders, showing the exact message might be helpful to the user what exactly is the issue.
packages/esm-patient-orders-app/src/order-basket/order-basket.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/order-basket/order-basket.workspace.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-orders-app/src/order-basket/order-basket.workspace.tsx
Outdated
Show resolved
Hide resolved
usamaidrsk
force-pushed
the
ft-send-orders-on-creating-enconter
branch
from
329e58a
to
856641d
Compare
| const orders: Array<OrderPost> = []; | ||
| for (let grouping in patientItems) { | ||
| const groupOrders = patientItems[grouping]; | ||
| for (let i = 0; i < groupOrders.length; i++) { | ||
| const order = groupOrders[i]; | ||
| orders.push(postDataPrepFunctions[grouping](order, patientUuid, null)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of getting the orders from the store, the orders should be passed via the function arguments.
There was a problem hiding this comment.
Also, the function createEmptyEncounter should be renamed to saveOrdersWithNewEncounter, since we are also saving the orders in the same encounter request.
Requirements
Summary
This PR adds the functionality to save orders along with creating a new encounter if one didn't exist. Before two transactions existed, i.e one to create encounter first and then create orders.
Screenshots
add-orders-on-creating-encounters.mp4
Related Issue
O3-2117
Other