New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add CarbonMRS icon set and React components #969
base: main
Are you sure you want to change the base?
Conversation
Size Change: -584 kB (-15%) 👏 Total Size: 3.19 MB
ℹ️ View Unchanged
|
Seems like it would be great if we could avoid it, right? Even if all the icons shared their own bundle that would seem to be better than having them in openmrs.js.
Yes, I think they do. |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This is a draft PR for implementing the CarbonMRS icon set and replacing most uses of the Carbon icons with the custom icons. The root idea here is to leverage the existing SVG sprites system, so that all svgs are loaded only once and simply cloned in place as needed.
Currently, the main limitation of this implementation is the lack of actual SVG icons (the files here are simply placeholders), so things I'm looking for feedback on are:
openmrs.js
file).icon
component?Screenshots
Related Issue
Other