Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2489 - toDateObjectStrict returns null if the passed string is not considered a valid date #963

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

(fix) O3-2489 - toDateObjectStrict returns null if the passed string is not considered a valid date #963

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41da06d
O3-2489 - toDateObjectStrict returns null if the passed string is not…
lugandahymnalnew Mar 31, 2024
52ec985
O3-2489 - toDateObjectStrict returns null if the passed string is not…
kitaroghope Mar 31, 2024
a177b3d
O3-2489 - toDateObjectStrict returns null if the passed string is not…
kitaroghope Mar 31, 2024
c385325
O3-2489 - toDateObjectStrict returns null if the passed string is not…
kitaroghope Mar 31, 2024
317f0a9
Merge branch 'main' of https://github.com/kitaroghope/openmrs-esm-core
kitaroghope Mar 31, 2024
b110400
O3-2489 - toDateObjectStrict returns null if the passed string is not…
kitaroghope Apr 30, 2024
3d92049
(fix) O3-2489 - toDateObjectStrict returns null if the passed string …
kitaroghope May 19, 2024
4e38afb
Merge branch 'main' of https://github.com/kitaroghope/openmrs-esm-core
kitaroghope May 19, 2024
5d61d8f
(fix) O3-2489 - toDateObjectStrict returns null if the passed string…
kitaroghope May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/framework/esm-utils/src/omrs-dates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function isOmrsDateToday(date: DateInput) {
*/
export function toDateObjectStrict(omrsDateString: string): Date | null {
if (!isOmrsDateStrict(omrsDateString)) {
return null;
throw new Error(`\`toDateObjectStrict\` failed to parse date string "${omrsDateString}".`);
}

return dayjs(omrsDateString, isoFormat).toDate();
Expand Down