O3-2996: Add billing module to openmrs distro pom file and spa config…

[alaboso]

Description of what I changed

This PR is to introduce the Billing and StockManagement modules to the reference application. Billing requires Stock Management as a dependency.

• Added stock management backend module
• Added billing backend module
• Added stock management frontend module
• Added billing frontend module

Issue I worked on

see https://openmrs.atlassian.net/browse/O3-2996

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[gracepotma]

FYI @dkayiwa please note these backend modules are now coming into the RefApp - so if there are concerns with the backend, now is the time to address ;) :)

[gracepotma]

FYI folks: Amos does have a plan to decouple the billing module from the inventory module in the coming weeks.

[ojwanganto]

@gracepotma - that will be great. Will the module still be able to bill for services and stock (defined within/outside of the inventory) and how do we plan to keep the references to stock items?

[ODORA0]

LGTM

[gracepotma]

@gracepotma - that will be great. Will the module still be able to bill for services and stock (defined within/outside of the inventory) and how do we plan to keep the references to stock items?

@alaboso can you please kindly respond to @ojwanganto's good question here? We definitely need to know if this would impact the inventory workflows :)

In meantime @dkayiwa can you please review this PR? I want to know if you feel this is appropriate and ready to include in the RefApp release being cut this week on April 18th. :)

CC @ebambo

[ebambo]

@gracepotma - that will be great. Will the module still be able to bill for services and stock (defined within/outside of the inventory) and how do we plan to keep the references to stock items?

@alaboso can you please kindly respond to @ojwanganto's good question here? We definitely need to know if this would impact the inventory workflows :)

In meantime @dkayiwa can you please review this PR? I want to know if you feel this is appropriate and ready to include in the RefApp release being cut this week on April 18th. :)

CC @ebambo

@gracepotma thanks for push the review of this PR. Regarding @ojwanganto comment the plan is definitely to continue supporting any existing workflows. The decoupling is in line with the approach that is being discussed by the Interoperability squad. Happy to discuss this more in-depth on the billing squad on slack.

[nravilla]

Attempted the changes in the PR, but encountered errors preventing the start of both the stock management and billing modules. The specific error message observed in the admin is -

Module Stock Management cannot be started because it requires the following module(s): dataexchange,uicommons ${uicommonsModuleVersion},uiframework ${uiframeworkVersion},appframework ${appframeworkVersion},appui ${appuiVersion},coreapps ${coreappsVersion} Please install and start these modules first.

[alaboso]

Attempted the changes in the PR, but encountered errors preventing the start of both the stock management and billing modules. The specific error message observed in the admin is -

Module Stock Management cannot be started because it requires the following module(s): dataexchange,uicommons ${uicommonsModuleVersion},uiframework ${uiframeworkVersion},appframework ${appframeworkVersion},appui ${appuiVersion},coreapps ${coreappsVersion} Please install and start these modules first.

@nravilla - These dependencies have been removed in this PR with only dataexchange and webservices.rest remaining. I realised we can remove dataexchange (which is used to load metadata privileges and roles) in favour of initializer.
@slubwama what do you think? I will update this PR accordingly.

[dkayiwa]

@alaboso do we have the stockmanagement and billing modules on https://addons.openmrs.org/?

[dkayiwa]

@alaboso the billing module also fails to start with these errors in the logs: https://pastebin.com/tpXB42WL

[ojwanganto]

@dkayiwa can we try clearing the liquibase first? Try running the following and see if the error clears.

set foreign_key_checks=0;
drop table if exists cashier_bill ;
drop table if exists cashier_bill_line_item ;
drop table if exists cashier_bill_payment ;
drop table if exists cashier_bill_payment_attribute ;
drop table if exists cashier_cash_point ;
drop table if exists cashier_department ;
drop table if exists cashier_item ;
drop table if exists cashier_item_attribute ;
drop table if exists cashier_item_attribute_type ;
drop table if exists cashier_item_code ;
drop table if exists cashier_item_price ;
drop table if exists cashier_payment_mode ;
drop table if exists cashier_payment_mode_attribute_type ;
drop table if exists cashier_seq_group_sequence ;
drop table if exists cashier_seq_receipt_number_generator ;
drop table if exists cashier_timesheet;
set foreign_key_checks=1;
delete from liquibasechangelog where id like 'openhmis.cashier%';

[dkayiwa]

@dkayiwa can we try clearing the liquibase first? Try running the following and see if the error clears.

set foreign_key_checks=0; drop table if exists cashier_bill ; drop table if exists cashier_bill_line_item ; drop table if exists cashier_bill_payment ; drop table if exists cashier_bill_payment_attribute ; drop table if exists cashier_cash_point ; drop table if exists cashier_department ; drop table if exists cashier_item ; drop table if exists cashier_item_attribute ; drop table if exists cashier_item_attribute_type ; drop table if exists cashier_item_code ; drop table if exists cashier_item_price ; drop table if exists cashier_payment_mode ; drop table if exists cashier_payment_mode_attribute_type ; drop table if exists cashier_seq_group_sequence ; drop table if exists cashier_seq_receipt_number_generator ; drop table if exists cashier_timesheet; set foreign_key_checks=1; delete from liquibasechangelog where id like 'openhmis.cashier%';

@ojwanganto that will not work because as you clearly see here, that table is referenced https://github.com/openmrs/openmrs-module-billing/blob/main/omod/src/main/resources/liquibase.xml#L118 before it gets created https://github.com/openmrs/openmrs-module-billing/blob/main/omod/src/main/resources/liquibase.xml#L422