Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratest 302-Add an identifier for a patient #492

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

EdisonMeks
Copy link

@EdisonMeks EdisonMeks commented Oct 23, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • I have tested the changes locally and verified that they work as intended.
  • I have added comments to my code where necessary to help others understand my changes.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

This is a test for adding a new identifier for a patient

Screenshots

None.

Related Issue

https://issues.openmrs.org/browse/RATEST-302

Other

None.

import org.openmrs.contrib.qaframework.helper.Page;
import org.openqa.selenium.By;

public class PatientFormPage extends Page {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a patient registration form, a clinicianFacing patient form, what is it this form ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page has been deleted

import org.openqa.selenium.By;
import org.openqa.selenium.Keys;

public class PatientPage extends Page{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is patientManagementPage

…ent step in addNewIdentifier feature file and the step definition in AddNewIdentifierSteps
@kdaud
Copy link
Member

kdaud commented Oct 25, 2023

@EdisonMeks could you add a ticket url to this PR?

@EdisonMeks
Copy link
Author

@EdisonMeks
Copy link
Author

@kdaud I have added the ticket url.
Thanks for the review

@kdaud
Copy link
Member

kdaud commented Oct 25, 2023

Could you add it under the Requirements section here?

@EdisonMeks EdisonMeks changed the title Ratest 302 Ratest 302-Add an identifier for a patient Oct 25, 2023
@@ -24,4 +24,9 @@ public void searchPatientIdentifierOrPatientName(String text) {
waitForTextToBePresentInElement(SEARCH_STATUS,text.substring(0, text.length() - 1));
}

public void clickOnFirstPatient(String text) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method can only work for reference application not legacy ui, so if you are working towards legacyui, please continue.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks did the needful

@sherrif10
Copy link
Member

Could you check the failure please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants