Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changes to the readme.md file #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RandilaP
Copy link

@RandilaP RandilaP commented Jan 26, 2023

Description

  • Remove "My pull request only contains ONE single commit" checkbox from PR template

Related Issue

https://issues.openmrs.org/browse/RATEST-340

@jayasanka-sack
Copy link
Member

Thank you for opening the PR, @RandilaP! I appreciate your contribution. ❤️

As a reminder, we kindly ask that all PRs follow the best practices outlined in our guide, such as including the ticket number in the title and providing a link to the ticket as well as a clear description of the work that has been done in the PR description.

Here is a helpful guide for reference: https://wiki.openmrs.org/display/docs/Pull+Request+Tips.

@jayasanka-sack
Copy link
Member

Also, I think what is expected from the task is to move the following part to the readme:

There is a detailed guide for setting up the OpenMRS QA Framework locally, checkout the guide here.

Perhaps you might need to change the wording a bit.

Suggestion:

Remove the "installing dependencies" section and replace it with the following.

Setting up

There is a detailed guide for setting up the OpenMRS QA Framework locally, checkout the guide here.

@Piumal1999
Copy link
Collaborator

Any update on this @RandilaP ?

@RandilaP
Copy link
Author

@jayasanka-sack

@RandilaP
Copy link
Author

RandilaP commented Mar 2, 2023

@jayasanka-sack Could you please review this

Copy link
Member

@jayasanka-sack jayasanka-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think what is expected from the task is to move the following part to the readme:

There is a detailed guide for setting up the OpenMRS QA Framework locally, checkout the guide here.

Perhaps you might need to change the wording a bit.

Suggestion:

Remove the "installing dependencies" section and replace it with the following.

Setting up

There is a detailed guide for setting up the OpenMRS QA Framework locally, checkout the guide here.

@RandilaP I think you've missed this suggestion.

@dilankavishka
Copy link
Contributor

dilankavishka commented Apr 3, 2023

there is a confusion caused by the difference in descriptions. Could you please clarify which specific descriptions you are referring to? @RandilaP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants