Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/strip whitespace #1136

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

amastruserio
Copy link

@amastruserio amastruserio commented Apr 18, 2022

Reference Issue

Fixes #1125

What does this PR implement/fix? Explain your changes.

Update to pull request #1134. Deletion of test files from tasks folder reverted. Change appears to function as expected with proper formatting and passes unit tests.

@PGijsbers
Copy link
Collaborator

Thanks for the contributions, and sorry for the delay in our response. This change is quite invasive (as mentioned in the issue) so I want to ensure we can run our unit test suite before merging. However, unit tests currently do not work due to some issues with the test server. We hope to fix this over the coming month and I will revisit this PR.

@PGijsbers PGijsbers self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Whitespace stripped from XML files can lead to congruence
2 participants