Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow loose reinitialization from runs also #1006

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

PGijsbers
Copy link
Collaborator

See #1005.

If someone is able to complete this PR (e.g. add unit tests), then that would be greatly appreciated. Otherwise this will go stale for at least two weeks. Maybe @Neeratyoy ?

@PGijsbers PGijsbers marked this pull request as draft November 18, 2020 07:27
@Neeratyoy
Copy link
Contributor

Sure, I can take this up. If not this week, next week for sure.
To clarify, the main to-do would be to have some unit tests that work across sklearn versions with the strict version parameter set to False ?

@PGijsbers
Copy link
Collaborator Author

For this PR, that would be the extent of it. In general we need more documentation for the extension but that can also be a separate PR later (possibly even by someone else).

@Neeratyoy
Copy link
Contributor

Alright, I think I shall address this next week from Monday!

@PGijsbers
Copy link
Collaborator Author

Sorry this went off my radar. It looks like the added test fails?

@Neeratyoy
Copy link
Contributor

My bad. I made this push as a potential design for how the unit test can be written, wasn't expecting it to pass. Moreover, I think this PR needs to be rebased first. I am working on some other things, for now, targeting a release this week. Will pick this up hopefully next week!

@PGijsbers PGijsbers self-assigned this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants