Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum Rust toolchain to 1.77 #294

Merged
merged 2 commits into from Mar 25, 2024
Merged

Change minimum Rust toolchain to 1.77 #294

merged 2 commits into from Mar 25, 2024

Conversation

sebastiencs
Copy link
Contributor

@sebastiencs sebastiencs commented Mar 22, 2024

Use Rust 1.77, to be able to use the now stable array::each_ref instead of array::from_fn.

each_ref guarantee that the source and destination have the same length.
That will protect us from length mismatch in future refactoring, or when binprot types are updated

Copy link
Collaborator

@tizoc tizoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When this gets merged to develop please notify everybody about the new minimum required version.

@dkuehr
Copy link
Contributor

dkuehr commented Mar 22, 2024

Looks much better than the previous approach.
Btw, did you notice any speedup? (I suspect not much since in many cases the array elements are the same size as a reference)

@sebastiencs
Copy link
Contributor Author

Btw, did you notice any speedup? (I suspect not much since in many cases the array elements are the same size as a reference)

I didn't see any changes on performances. The arrays we're working with are probably not big enough

@sebastiencs sebastiencs merged commit 1320444 into develop Mar 25, 2024
8 of 11 checks passed
@sebastiencs sebastiencs deleted the rust-1.77 branch March 25, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants