Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature type to vector source signature #15774

Merged
merged 1 commit into from Apr 27, 2024
Merged

Add feature type to vector source signature #15774

merged 1 commit into from Apr 27, 2024

Conversation

sebakerckhof
Copy link
Contributor

Found another case where the feature type generic was not taken into account

@github-actions GitHub Actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-15774--ol-site.netlify.app/.

ahocevar
ahocevar approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sebakerckhof

@ahocevar ahocevar self-requested a review April 27, 2024 06:25
ahocevar
ahocevar requested changes Apr 27, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think this will not work. The this.on and this.once signatures would need to include the FeatureClass template of the class, otherwise it cannot be inferred.

ahocevar
ahocevar approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it does work. Thanks!

@ahocevar ahocevar merged commit c6ddb3e into openlayers:main Apr 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahocevar ahocevar ahocevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebakerckhof @ahocevar