Show how to combine a layer with a render function and a standard layer #15762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15762--ol-site.netlify.app/. |
|
Preview of the updated example: https://deploy-preview-15762--ol-site.netlify.app/en/latest/examples/svg-layer.html |
MoonE
approved these changes
Apr 24, 2024
examples/svg-layer.js
Outdated
| @@ -47,8 +52,21 @@ map.addLayer( | |||
| center[1] / svgResolution - height / 2, | |||
| ); | |||
| svgContainer.style.transform = cssTransform; | |||
| svgContainer.style.opacity = this.getOpacity(); | |||
| svgContainer.style.opacity = this.getOpacity() || 1; | |||
There was a problem hiding this comment.
Why the || 1?
this.getOpacity() always returns 1 here; and what if opacity is zero?
There was a problem hiding this comment.
The idea was to avoid that the style ends up being the string 'undefined' if `getOpacity() returns undefined, which is not valid CSS. If it always returns 1, that's not necessary. Let me try. If it works, I'm going to remove this change.
There was a problem hiding this comment.
You were absolutely right, @MoonE . I undid the opacity change. Thanks for the sharp eye.
ahocevar
force-pushed
the
svg-layer-opacity
branch
from
f8ec79c
to
d0e26bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #15758. This example change should make life easier for users who want to combine standard layers with a layer with a custom render function.