Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:GML2:readFlatCoordinates can return the format of (x,y) or (y,x) #15675

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jacklinna
Copy link

@jacklinna jacklinna commented Mar 27, 2024

Fixes #15617

Copy link

📦 Preview the website for this branch here: https://deploy-preview-15675--ol-site.netlify.app/.

src/ol/format/GML2.js Outdated Show resolved Hide resolved
src/ol/format/GML2.js Outdated Show resolved Hide resolved
@ahocevar
Copy link
Member

ahocevar commented Mar 29, 2024

Thanks, @jacklinna. You'd also have to update the tests.

src/ol/format/GML2.js Outdated Show resolved Hide resolved
src/ol/format/GML2.js Outdated Show resolved Hide resolved
@ahocevar
Copy link
Member

ahocevar commented Mar 29, 2024

Also, the failing tests show that the fix might not be as straightforward as you thought. This one for example:

Chrome Headless 123.0.0.0 (Linux x86_64) ol.format.WFS when parsing mapserver GML2 polygon creates a polygon for My Polygon with hole FAILED
	Error: expected [ 47.003018, -0.768746, 0.532597, undefined ] to sort of equal [ 47.003018, -0.768746, 47.925567, 0.532597 ]
	    at Assertion.assert (/home/runner/work/openlayers/openlayers/node_modules/expect.js/index.js:96:13)
	    at Assertion.eql (/home/runner/work/openlayers/openlayers/node_modules/expect.js/index.js:230:10)
	    at Context.<anonymous> (/tmp/_karma_webpack_683077/webpack:/ol/test/browser/spec/ol/format/wfs.test.js:141:1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GML format always returns 3d geometries
2 participants