New image tile source #15568
Open
New image tile source #15568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaub
force-pushed
the
new-source-redux
branch
from
20f9deb
to
2e392f8
Compare
|
📦 Preview the website for this branch here: https://deploy-preview-15568--ol-site.netlify.app/. |
tschaub
force-pushed
the
new-source-redux
branch
6 times, most recently
from
4089938
to
11efc9c
Compare
tschaub
force-pushed
the
new-source-redux
branch
from
11efc9c
to
d9b58db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of the changes in #14262. I needed to squash the commits to deal with all the conflicts in the past couple years.
This adds a new
ol/source/ImageTile.jsmodule that is intended to replace the following:ol/source/UrlTile.jsol/source/TileImage.jsol/source/XYZ.jsol/ImageTile.jsol/tileurlfunction.jsThe new source accepts a
urloption that can be a single URL template, an array of URL templates, or a function that returns a URL. The resulting loader returns a promise that creates an image, sets its src, and resolves when the image loads. For more complex image loading scenarios, the source can be passed aloaderoption.Since we have some breaking changes already merged in, I thought it could make sense to deprecate a few things and merge this in.
When we are ready to remove
ol/source/TileImage.js, we can update the the 9 sources that extendTileImageto instead extend theImageTilesource. This will be a breaking change since some of the options no longer make sense (tileLoadFunction,urls,cacheSize).