Add unsnap event #15494
Open
Add unsnap event #15494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15494--ol-site.netlify.app/. |
ahocevar
reviewed
Jan 29, 2024
ahocevar
reviewed
Jan 29, 2024
ahocevar
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Thanks for your contribution, @eklauberg. See my in-line comments for suggested changes.
ahocevar
requested changes
Feb 2, 2024
Comment on lines
+223
to
+225
| * @type {SnappedInfo|null} | ||
| * @private | ||
| * @description Holds information about the last snapped state. |
There was a problem hiding this comment.
Suggested change
| * @type {SnappedInfo|null} | |
| * @private | |
| * @description Holds information about the last snapped state. | |
| * Holds information about the last snapped state. | |
| * @type {SnappedInfo|null} | |
| * @private |
| areSnapDataEqual_(data1, data2) { | ||
| return ( | ||
| data1.vertex[1] === data2.vertex[1] && | ||
| data1.feature?.getId() === data2.feature?.getId() |
There was a problem hiding this comment.
Features do not need an id, but the feature reference will be the same if the features are the same
Suggested change
| data1.feature?.getId() === data2.feature?.getId() | |
| data1.feature === data2.feature |
| this.dispatchEvent(new SnapEvent(SnapEventType.UNSNAP, this.snapped_)); | ||
| } | ||
|
|
||
| if (!this.snapped_ || !this.areSnapDataEqual_(this.snapped_, result)) { |
There was a problem hiding this comment.
Instead of calling areSnapDataEqual_() again here, you could store it in a variable above.
| */ | ||
| areSnapDataEqual_(data1, data2) { | ||
| return ( | ||
| data1.vertex[1] === data2.vertex[1] && |
There was a problem hiding this comment.
I think you'll want to check equality for the segment instead. I'd expect an unsnap event only when snapping leaves a segment, not whenever I move the cursor.
Suggested change
| data1.vertex[1] === data2.vertex[1] && | |
| data1.segment === data2.segment && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue: #15404